add encodeHtmlEntities option #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanclarke
force-pushed
the
entities-option
branch
2 times, most recently
from
dc3bc92 to
4ad917f
Compare
| var testCases = [ | ||
| { | ||
| options: { encodeHtmlEntities: true }, | ||
| src: '<!DOCTYPE html><html><head></head><body>&</body></html>', |
There was a problem hiding this comment.
Could we add something like <a href="http://example.com?hello=1&world=2"></a> here so that we're also testing that this applies to attribute values as well?
There was a problem hiding this comment.
yeah, good point!
There was a problem hiding this comment.
Also, I think we should use & in the src instead of a bare &. The & would be valid HTML.
alanclarke
force-pushed
the
entities-option
branch
from
ad32311 to
cb1ae72
Compare
|
@alanclarke Thank you! In general it looks good, but there are some remarks. |
alanclarke
force-pushed
the
entities-option
branch
from
cb1ae72 to
3836b0a
Compare
alanclarke
force-pushed
the
entities-option
branch
from
3836b0a to
9c2abb2
Compare
inikulin
added a commit
that referenced
this pull request
Dec 19, 2014
add encodeHtmlEntities option
|
Woohoo! 👍 Thanks Ivan and Alan! |
|
@winhamwr @alanclarke Thank you, guys. I'll try to prepare a new release within a couple of days. |
|
Awesome! |
|
New version 1.3.0 with this functionality was published to npm |
Closed
43081j
pushed a commit
to 43081j/parse5
that referenced
this pull request
Dec 28, 2021
Bumps [jest](https://github.com/facebook/jest) from 27.4.4 to 27.4.5. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](jestjs/jest@v27.4.4...v27.4.5) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.