Rework how we refine information from callable() #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't ever assume that something is *not* callable; basically anything could be, and getting it wrong leaves code to not be typechecked. When operating on an Instance that is not clearly callable, construct a callable version of it by generating a fake subclass with a __call__ method to be used. Fixes python#3605
inirudebwoy
commented
Dec 13, 2017
mypy/checker.py
Outdated
|
|
||
| # Build the fake ClassDef and TypeInfo together. | ||
| # The ClassDef is full of lies and doesn't actually contain a body. | ||
| cdef = ClassDef("<callable subtype of {}>".format(type.type.name()), Block([])) |
There was a problem hiding this comment.
This is bad ⚰️ come on dude
There was a problem hiding this comment.
hmmm how do I close this?
| callables.extend(subcallables) | ||
| uncallables.extend(subuncallables) | ||
| return callables, uncallables | ||
|
|
||
| if isinstance(type, TypeVarType): | ||
| return partition_by_callable(type.erase_to_union_or_bound()) | ||
| # We could do better probably? |
| left_if_vars, left_else_vars = find_isinstance_check(node.left, type_map) | ||
| right_if_vars, right_else_vars = find_isinstance_check(node.right, type_map) | ||
| left_if_vars, left_else_vars = find_isinstance_check(node.left, type_map, typechecker) | ||
| right_if_vars, right_else_vars = find_isinstance_check(node.right, type_map, typechecker) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't ever assume that something is not callable; basically anything
could be, and getting it wrong leaves code to not be typechecked.
When operating on an Instance that is not clearly callable, construct
a callable version of it by generating a fake subclass with a call
method to be used.
Fixes python#3605