feat: adding epss data #3104
feat: adding epss data #3104
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3104 +/- ##
==========================================
- Coverage 82.46% 79.66% -2.81%
==========================================
Files 714 714
Lines 10984 10931 -53
Branches 1477 1264 -213
==========================================
- Hits 9058 8708 -350
- Misses 1543 1827 +284
- Partials 383 396 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
(1) the cvedb.py file isn'r required in this PR
(2) Suggest that the test file is renameed to be something like epss_scores_test.csv
(3) Suggestion that we add a test to check that cache processing is working
(4) What happens if the file can't be downloaded/found?
|
@anthonyharrison I have applied your suggestion, and for right now if the file is not downloaded or found, it will give this error |
There was a problem hiding this comment.
I think you should add a test to check for downloading of epss data as well, just as @anthonyharrison suggested.
| time_difference = datetime.now() - last_modified | ||
|
|
||
| # Check if the file is older than 24 hours | ||
| if time_difference < timedelta(hours=24): |
There was a problem hiding this comment.
shouldn't this be if time_difference > timedelta(hours=24): as epss data should be downloaded if file is older than 24 hours?
There was a problem hiding this comment.
Since @Rexbeast2 mentioned yesterday that it would be easier if we had some stuff merged so he could work on the next piece over the weekend, and this one is at least passing all tests, I'm going to go ahead and merge this now before I'm offline for the US long weekend. If it needs a bit more work to improve error handling then it can be done in a future PR.
fixes: #3103