Skip to content

Necessary Support for Newer Linux Distros #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kimmeljo
Copy link

Description & Motivation

Newer Linux distros complain about installing things globally via pip. This is problematic for hard dependencies of Cosim like cocotb. This PR introduces Python virtual environments into the Cosim flow to make these newer distros happy.

Related Issue(s)

N/A

Testing

All testing is theoretical transparent in the existing tests as the change should be fully backwards compatible. But if more explicit testing is desired, it can be added.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Not a breaking change. Everything should still work on older systems too. We are just using a Python virtual environment.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Not doc updates for now but some might be warranted?

@mkorbel1
Copy link
Contributor

#52 will fix lint issues you ran into I think

@kimmeljo
Copy link
Author

#52 will fix lint issues you ran into I think

@mkorbel1 do I need to wait for a ROHD release to get these changes? Looks like the cosim repo doesn't override the rohd dependency to point to main.

@mkorbel1
Copy link
Contributor

#52 will fix lint issues you ran into I think

@mkorbel1 do I need to wait for a ROHD release to get these changes? Looks like the cosim repo doesn't override the rohd dependency to point to main.

No, you can just pull main of rohd-cosim which now has the fixes

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants