-
Notifications
You must be signed in to change notification settings - Fork 5
Necessary Support for Newer Linux Distros #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimmeljo
wants to merge
4
commits into
intel:main
Choose a base branch
from
kimmeljo:venv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Jun 16, 2025
mkorbel1
reviewed
Jun 17, 2025
mkorbel1
reviewed
Jun 17, 2025
#52 will fix lint issues you ran into I think |
mkorbel1
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Newer Linux distros complain about installing things globally via pip. This is problematic for hard dependencies of Cosim like cocotb. This PR introduces Python virtual environments into the Cosim flow to make these newer distros happy.
Related Issue(s)
N/A
Testing
All testing is theoretical transparent in the existing tests as the change should be fully backwards compatible. But if more explicit testing is desired, it can be added.
Backwards-compatibility
Not a breaking change. Everything should still work on older systems too. We are just using a Python virtual environment.
Documentation
Not doc updates for now but some might be warranted?