Skip to content

fix(localenv): use https in openPaymentsUrl vars in local backend config #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

njlie
Copy link
Contributor

@njlie njlie commented May 2, 2025

Changes proposed in this pull request

  • Use https in the OPEN_PAYMENTS_URL backend environment variable for the local environment configuration.

Context

Closes #3409.

After #3325 was merged in, the seeding for the local environment was broken since wallet addresses were being compared against the OPEN_PAYMENTS_URL - and the discrepancy in http protocol between the local environment config for backend and the submitted wallet addresses in the seed caused the wallet address creation to fail during seeding.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

Copy link

github-actions bot commented May 2, 2025

🚀 Performance Test Results

Performance test summary not found.

📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set


  █ TOTAL RESULTS 

    HTTP
    http_req_duration....................: avg=1.86ms min=1.86ms med=1.86ms max=1.86ms p(90)=1.86ms p(95)=1.86ms
    http_req_failed......................: 100.00% 1 out of 1
    http_reqs............................: 1       283.596066/s

    NETWORK
    data_received........................: 232 B   66 kB/s
    data_sent............................: 505 B   143 kB/s



/home/runner/work/rafiki/rafiki/test/performance:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  [email protected] run-tests:testenv: `./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"`
Exit status 107

@njlie njlie merged commit 0d5499f into 2893/multi-tenancy-v1 May 2, 2025
38 checks passed
@njlie njlie deleted the nl/3409/fix-mt-localenv branch May 2, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants