Fix pytests for openlibrary/records again #3708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2020
cclauss
changed the title
mekarpeles
reviewed
Aug 22, 2020
| """Converts list of things into the output expected by users of the search API. | ||
|
|
||
| If input_query is non empty, narrow return keys to the ones in | ||
| this dictionary. Also, if the keys list is empty, use this to | ||
| construct a response with key = None. | ||
| """ | ||
| input_query = input_query or {} # Avoid a mutable default argument |
mekarpeles
reviewed
Aug 22, 2020
| ret = web.ctx.site.save_many(things, 'Import new records.') | ||
| return [x.key for x in ret] | ||
| web.ctx.site.save_many(things, 'Import new records.') | ||
| return [thing['key'] for thing in things] |
There was a problem hiding this comment.
seems fine, leaving a note/question re: whether we can guarantee 'key' is indeed a key, i.e. thing.get('key') v. thing['key'] but I imagine if thing is not None, it should have key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3586 and #3706 Enables
pytest -vv openlibrary/recordsand uncovers:json.dumps()to compare dicts across both Python 2 and Python 3Technical
Testing
Yes. In Docker on both Python 2 and Python 3
Screenshot
Stakeholders