Skip to content

invenio: refactor datacite block #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

egabancho
Copy link
Member

@egabancho
Copy link
Member Author

I haven't tested this one yet.

Copy link
Contributor

@lindhe lindhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check my comment. Other than that, I think this looks good.

* Deprecates non-camelcase datacite variables.

* Addresses secret handling as described in inveniosoftware#117.
@egabancho egabancho requested a review from lindhe April 1, 2025 12:56
@egabancho egabancho marked this pull request as ready for review April 1, 2025 12:56
Copy link
Contributor

@lindhe lindhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time to test this PR, but I think it looks good. Feel free to merge; we can fix bugs later if we discover them.

If I do get time to test run this, I'll write. But I approve it anyway, just check my last remaining suggestion.

@egabancho egabancho merged commit c49d980 into inveniosoftware:master Apr 4, 2025
1 check passed
@egabancho egabancho deleted the datacite branch April 4, 2025 10:24
@lindhe lindhe linked an issue Apr 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make INVENIO_DATACITE_ENABLED configurable
2 participants