-
Notifications
You must be signed in to change notification settings - Fork 22
invenio: refactor datacite block #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I haven't tested this one yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check my comment. Other than that, I think this looks good.
* Deprecates non-camelcase datacite variables. * Addresses secret handling as described in inveniosoftware#117.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to test this PR, but I think it looks good. Feel free to merge; we can fix bugs later if we discover them.
If I do get time to test run this, I'll write. But I approve it anyway, just check my last remaining suggestion.
Co-authored-by: Andreas Lindhé <[email protected]>
Deprecates non-camelcase datacite variables.
Addresses secret handling as described in Secret handling - where should passwords, etc. be added #117.