values: refactor image block #174
Conversation
Impossible to know, the author of that issue never described why that wanted the change. 😄 But if we do any refactoring like this, let's just mark their issue as closed and then let them reopen it if we didn't fix it. In my opinion, replacing the |
|
I don't think allowing different images for the various components is such a good idea. All sorts of things can happen, and that's why everywhere else the same one is used. This is not the best example, but it's the one I have at hand https://github.com/inveniosoftware/cookiecutter-invenio-rdm/blob/master/%7B%7Bcookiecutter.project_shortname%7D%7D/docker-compose.full.yml I wouldn't mind removing the deprecation warning from |
|
Fair enough, I won't contest that. Let's keep it a single global Review incoming. |
When `.Values.image.imagePullSecrets` was introduced in #174, we opted to use the same format for `imagePullSecrets` list as used in Kubernetes' PodSpec; it's a list of objects that requires each list element to have the key `name`. We failed to indicate this in the example given in the comment. This change fixes that.
When `.Values.image.imagePullSecrets` was introduced in #174, we opted to use the same format for `imagePullSecrets` list as used in Kubernetes' PodSpec; it's a list of objects that requires each list element to have the key `name`. We failed to indicate this in the example given in the comment. This change fixes that.
Does this close #14?