Skip to content

fix: Use correct default image values #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Conversation

lindhe
Copy link
Contributor

@lindhe lindhe commented Apr 16, 2025

Description

  • Use 12.0.10 instead of v12.0.10 in appVersion, so it's compliant with the tag of the default image.
  • Fix typo ghrc.io --> ghcr.io
  • Fix typo where image name was part of the tag.
  • DRY: Unset the tag value, so we default to using appVersion.
  • Unset deprecated image fields.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@lindhe lindhe marked this pull request as ready for review April 16, 2025 18:58
@lindhe lindhe requested a review from egabancho April 16, 2025 18:58
@lindhe lindhe self-assigned this Apr 16, 2025
- Use `12.0.10` instead of `v12.0.10` in `appVersion`, so it's compliant
  with the tag of the default image.
- Fix typo ghrc.io --> ghcr.io
- Fix typo where image name was part of the tag.
- DRY: Unset the `tag` value, so we default to using `appVersion`.
@lindhe lindhe force-pushed the lindhe/fix-default-tag branch from d734143 to 5cc2b27 Compare April 17, 2025 06:18
@lindhe
Copy link
Contributor Author

lindhe commented Apr 17, 2025

In https://github.com/inveniosoftware/helm-invenio/actions/runs/14500405731 the linting failed because of too few spaces before a comment. That's not part of Helm lint, is there also some YAML linting included here? 🤔 Any idea how to best formalize the linting rules so one can test them locally before pushing?

This suppresses the deprecation notice, unless the user explicitly sets
the deprecated fields.

This change should be non-breaking, since we've set the image via
`.Values.image` already.
@egabancho
Copy link
Member

The CI action uses the chart-testing tool behind the scenes. In particular, ct lint which

Run 'helm lint', version checking, YAML schema validation on 'Chart.yaml', YAML linting on 'Chart.yaml' and 'values.yaml', and maintainer validation

@lindhe lindhe merged commit 83a2d50 into master Apr 17, 2025
1 check passed
@lindhe lindhe deleted the lindhe/fix-default-tag branch April 17, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants