Skip to content

fix: Improve missing resources warning #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

Conversation

lindhe
Copy link
Contributor

@lindhe lindhe commented Apr 17, 2025

Description

This change improves the logic for when the warning about missing resources should be printed.
Before, it printed even for disabled resources.
Now, it does not print a warning for disabled resources and it dynamically checks for initContainers subresources.

Fixes #182

Tip

This change is easier to review if you ignore space changes.

git show --ignore-space-change

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

This change improves the logic for when the warning about missing
resources should be printed.
Before, it printed even for disabled resources.
Now, it does not print a warning for disabled resources and it
dynamically checks for `initContainers` subresources.

Fixes #182
@lindhe lindhe self-assigned this Apr 17, 2025
@lindhe lindhe requested a review from egabancho April 17, 2025 08:05
@lindhe lindhe merged commit dc7c293 into master Apr 21, 2025
1 check passed
@lindhe lindhe deleted the lindhe/fix-resources-warning branch April 21, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "MISSING RESOURCES" notes
2 participants