Skip to content

chore: Set datacite secret using new parameter #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

lindhe
Copy link
Contributor

@lindhe lindhe commented Apr 17, 2025

Description

This change unsets the deprecated invenio.datacite.secret_name value, which has been repaced by invenio.datacite.existingSecret, so that the deprecation warning only shows up if a user has explicitly set the deprecated value.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

This change unsets the deprecated `invenio.datacite.secret_name` value,
which has been repaced by `invenio.datacite.existingSecret`, so that the
deprecation warning only shows up if a user has explicitly set the
deprecated value.
@lindhe lindhe requested a review from egabancho April 17, 2025 08:19
@lindhe lindhe self-assigned this Apr 17, 2025
@lindhe lindhe merged commit 3db8070 into master Apr 18, 2025
1 check passed
@lindhe lindhe deleted the lindhe/datacite-secret-deprecation-notice branch April 18, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants