datacite: add configuration variables #186
Open
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egabancho
commented
Apr 21, 2025
lindhe
reviewed
Apr 22, 2025
lindhe
reviewed
Apr 22, 2025
|
Left some minor comments. Once the conversations get resolved I'll approve this. |
egabancho
force-pushed
the
datacite-configuration
branch
from
75d3438 to
6cac2f3
Compare
lindhe
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds all the DataCite configuration variables to the
invenio.dataciteblock, which, IMHO, is better than having them spread all around yourvalues.yaml.