Skip to content

values: allow templates on invenio.hostname #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

values: allow templates on invenio.hostname #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/invenio/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Return the proper Invenio image name
This template renders the hostname for Invenio.
*/}}
{{- define "invenio.hostname" -}}
{{- required "Missing .Values.invenio.hostname" .Values.invenio.hostname }}
{{- tpl (required "Missing .Values.invenio.hostname" .Values.invenio.hostname) . }}
{{- end -}}

############################ Redis Hostname ############################
Expand Down
2 changes: 2 additions & 0 deletions charts/invenio/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ ingress:
tlsSecretNameOverride: ""

invenio:
## @param invenio.hostname Invenio hostname (templated) used in configuration varibales like APP_ALLOWED_HOSTS, SITE_HOSTNAME or SITE_URL
##
hostname: ""
## @param invenio.secret_key DEPRECATED: this is automatically generated now, or set by custom secret using invenio.existingSecret
##
Expand Down