Skip to content

PIDUnregistered Console Error when Submitting Review Requests to Draft Record #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Samk13 opened this issue Sep 24, 2024 · 0 comments · Fixed by inveniosoftware/invenio-rdm-records#1822
Labels
bug Something isn't working

Comments

@Samk13
Copy link
Member

Samk13 commented Sep 24, 2024

Package version (if known): V12, V13

Describe the bug

A console error appears when submitting a draft for review on the request page in fresh instances of v12 or v13. The error seems related to the absence of draft IDs.

when Invenio searches for the record's communities it will fail to resolve the draft ID as it has not yet been registered.

Steps to Reproduce

  1. Open a fresh instance of v12 or v13.
  2. Add a community and submit the record for review.
  3. in the request page try to refresh.
  4. Observe the console error.

Expected behavior

No console error should appear and the error should be handled gracefully.

Logs

Details
Traceback (most recent call last):
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/flask/app.py", line 1823, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/flask_resources/resources.py", line 65, in view
    return view_meth()
           ^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/flask_resources/content_negotiation.py", line 116, in inner_content_negotiation
    return f(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/flask_resources/parsers/decorators.py", line 51, in inner
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/flask_resources/parsers/decorators.py", line 51, in inner
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/flask_resources/responses.py", line 39, in inner
    res = f(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/invenio_rdm_records/resources/resources.py", line 337, in search
    items = self.service.search(
            ^^^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/invenio_rdm_records/services/communities/service.py", line 249, in search
    record = self.record_cls.pid.resolve(id_)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/invenio_records_resources/records/systemfields/pid.py", line 77, in resolve
    pid, record = resolver.resolve(pid_value)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/test-user/.pyenv/versions/3.12.6/envs/v12-playground/lib/python3.12/site-packages/invenio_pidstore/resolver.py", line 56, in resolve
    raise PIDUnregistered(pid)
invenio_pidstore.errors.PIDUnregistered
127.0.0.1 - - [23/Sep/2024 16:37:39] "GET /api/records/hb2kr-qgw40/communities HTTP/1.1" 404 -

@Samk13 Samk13 added the bug Something isn't working label Sep 24, 2024
Samk13 added a commit to Samk13/invenio-rdm-records that referenced this issue Sep 26, 2024
* Records: catch PIDUnregistered error
* Add draft class to RecordCommunitiesService
* Closes inveniosoftware/invenio-app-rdm#2857
Samk13 added a commit to Samk13/invenio-rdm-records that referenced this issue Sep 30, 2024
* Records: catch PIDUnregistered error
* Add draft class to RecordCommunitiesService
* Closes inveniosoftware/invenio-app-rdm#2857
Samk13 added a commit to inveniosoftware/invenio-rdm-records that referenced this issue Sep 30, 2024
)

* Records: catch PIDUnregistered error
* Add draft class to RecordCommunitiesService
* Closes inveniosoftware/invenio-app-rdm#2857
Samk13 added a commit to Samk13/invenio-rdm-records that referenced this issue Sep 30, 2024
…veniosoftware#1822)

* Records: catch PIDUnregistered error
* Add draft class to RecordCommunitiesService
* Closes inveniosoftware/invenio-app-rdm#2857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant