WIP: init: build redis url from its parts if available #29
+79
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part of inveniosoftware/invenio-config#57, focusing on the Cache/Redis side of things
It's still WIP.
Note that the configuration
CACHE_REDIS_URL(or similar variants) is used in other Invenio/Flask packages as well.Here's a short list of findings (
rg -uu 'REDIS.*URL'in my instance's venv):Which of those are potentially problematic needs some more investigation, I'm thinking primarily about startup order collisions here (since the extension initialization is currently [Invenio-Config 1.0.4] non-deterministic).