meeting: replace URL with identifiers (breaking change)

* closes #1972

Author: kpsherva

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/customFields/Meeting.js

@@ -5,22 +5,30 @@
 // Invenio-RDM-Records is free software; you can redistribute it and/or modify it
 // under the terms of the MIT License; see LICENSE file for more details.
 
+import { IdentifiersField } from "@js/invenio_rdm_records/src/deposit/fields";
+import { i18next } from "@translations/invenio_rdm_records/i18next";
 import React, { Component } from "react";
-
+import { getInputFromDOM } from "@js/invenio_rdm_records";
 import { FieldLabel, Input } from "react-invenio-forms";
 import { Divider, Grid } from "semantic-ui-react";
 
 import PropTypes from "prop-types";
 
 export class Meeting extends Component {
+  constructor(props) {
+    super(props);
+    this.config = getInputFromDOM("deposits-config");
+    this.vocabularies = this.config.vocabularies;
+  }
+
   render() {
     const {
       fieldPath, // injected by the custom field loader via the `field` config property
       title,
       acronym,
       dates,
       place,
-      url,
+      // identifiers,
       session,
       session_part: sessionPart,
       icon,
@@ -75,15 +83,14 @@ export class Meeting extends Component {
               <label className="helptext mb-0">{dates.description}</label>
             )}
           </Grid.Column>
-          <Grid.Column width="12">
-            <Input
-              fieldPath={`${fieldPath}.url`}
-              label={url.label}
-              placeholder={url.placeholder}
+          <Grid.Column width="16">
+            <IdentifiersField
+              fieldPath={`${fieldPath}.identifiers`}
+              label={i18next.t("Meeting identifiers")}
+              labelIcon="barcode"
+              schemeOptions={this.vocabularies.identifiers.scheme}
+              showEmptyValue
             />
-            {url.description && (
-              <label className="helptext mb-0">{url.description}</label>
-            )}
           </Grid.Column>
           <Grid.Column width="6">
             <Input
@@ -117,7 +124,7 @@ Meeting.propTypes = {
   acronym: PropTypes.object.isRequired,
   session_part: PropTypes.object.isRequired,
   session: PropTypes.object.isRequired,
-  url: PropTypes.object.isRequired,
+  // identifiers: PropTypes.object.isRequired,
   dates: PropTypes.object.isRequired,
   place: PropTypes.object.isRequired,
   icon: PropTypes.string,

invenio_rdm_records/contrib/meeting/custom_fields.py

@@ -17,13 +17,15 @@
 - meeting.title
 - meeting.url
 """
+from functools import partial
 
 from invenio_i18n import lazy_gettext as _
 from invenio_records_resources.services.custom_fields import BaseCF
 from marshmallow import fields
-from marshmallow_utils.fields import SanitizedUnicode
+from marshmallow_utils.fields import SanitizedUnicode, IdentifierValueSet
+from marshmallow_utils.schemas import IdentifierSchema
 
-from ...services.schemas.metadata import _valid_url
+from ...services.schemas.metadata import record_identifiers_schemes
 
 
 class MeetingCF(BaseCF):
@@ -40,9 +42,12 @@ def field(self):
                 "session_part": SanitizedUnicode(),
                 "session": SanitizedUnicode(),
                 "title": SanitizedUnicode(),
-                "url": SanitizedUnicode(
-                    validate=_valid_url(error_msg=_("You must provide a valid URL.")),
-                ),
+                "identifiers": IdentifierValueSet(
+                    fields.Nested(
+                        partial(IdentifierSchema,
+                                allowed_schemes=record_identifiers_schemes)
+                    )
+                )
             }
         )
 
@@ -61,7 +66,11 @@ def mapping(self):
                     "type": "text",
                     "fields": {"keyword": {"type": "keyword"}},
                 },
-                "url": {"type": "keyword"},
+                "identifiers": {"type": "object",
+                                "properties": {
+                                    "identifier": {"type": "keyword"},
+                                    "schema": {"type": "keyword"}
+                                }},
             },
         }
 
@@ -71,7 +80,6 @@ def mapping(self):
     "meeting": "",
 }
 
-
 MEETING_CUSTOM_FIELDS = [
     MeetingCF(name="meeting:meeting"),
 ]
@@ -104,10 +112,8 @@ def mapping(self):
                     "placeholder": "",
                     "description": _("Location where the conference took place."),
                 },
-                "url": {
-                    "label": _("Website"),
-                    "placeholder": "",
-                    "description": "",
+                "identifiers": {
+                    "label": _("Identifiers"),
                 },
                 "session": {
                     "label": _("Session"),