feat(ui): img2img UX 2 #7090
Merged
feat(ui): img2img UX 2 #7090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an entity needs to do something after init, it can use this system. For example, if a layer should be transformed immediately after initializing, it can use an init callback.
This replicates the img2img flow: - Reset the canvas - Resize the bbox to the image's aspect ratio at the optimal size for the selected model - Add the image as a raster layer - Resizes the layer to fit the bbox using the 'fill' strategy After this completes, the user can immediately click Invoke and it will do img2img.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
|
I agree about the “New Canvas” resizing automatically. I think we’ve gotta streamline that Regarding the size, I think you’ve made the right call. Having leftover pixels would be confusing for users. We will just need to explain that well enough |
hipsterusername
approved these changes
Oct 10, 2024
|
Have merged this in any case, change to the button can be done as a follow on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CanvasEntityTransformerto prevent concurrent operationsNew Img2Img from ImageRelated Issues / Discussions
Scattered discord & offline discussions
QA Instructions
To test the functionality
New Img2Img from Image, which should:img2img.Discussion points
I've left
New Canvas from ImageandNew Img2Img from Imageseparate, but maybe it's better to not add a new button for img2img and instead update the behaviour ofNew Canvas from Image.Because the image can be of any size (e.g. not perfect multiples of 8/16), we will typically need to make a small concession with the image or bbox size. Two approaches:
fillstrategy, so its final aspect ratio may be slightly different, but it will fit the bbox perfectly. This is the approach used in this PR. I think it's closer to what the user wants, and better replicates the old img2img flow.Merge Plan
n/a
Checklist