fix: Pin onnx versions to builds that don't require rare dlls #7107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
lstein,
blessedcoolant and
hipsterusername
as code owners
maryhipp
approved these changes
Oct 12, 2024
hipsterusername
approved these changes
Oct 12, 2024
brandonrising
force-pushed
the
brandon/fix-onnx-versions
branch
from
84d9276 to
5212a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On current main, many users are experiencing the following error while trying to run the app.
According to this issue on the onnx github, as well as various other issue reports, it seems like more recent versions of onnx require a dll that many users don't have on windows machines. I will call out that it does work on my personal windows machine with the latest onnx build, but I suspect it requires ddls received from the latest visual studio tools installation, which many users will not have installed.
To remedy this in the short term, this PR fixes the versions to versions of onnx that are known to work when receiving the above error.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1293975018082144287
QA Instructions
If experiencing the above error on 5.1.1, attempt to start the app with these onnx packages installed
Merge Plan
Can be merged when tested and approved.
Checklist