Skip to content

Maryhipp/bulk upload #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 16, 2024
Merged

Maryhipp/bulk upload #7123

merged 12 commits into from
Oct 16, 2024

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Oct 16, 2024 •
edited
Loading

Summary

  • Add upload button to gallery that supports single and multi image upload
  • Update fullscreen dropzone to support multiple image upload
  • Use toast that doesn't close for multiple image upload so that the count correctly reflects how many images are being uploaded
  • Remove double add-to-board logic that was happening in upload image listener

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Oct 16, 2024
@maryhipp maryhipp marked this pull request as ready for review October 16, 2024 00:48
@psychedelicious
feat(ui): simpler useImageUploadButton
0ad27b0 
We can always iterate over `files`, no need for any conditional logic here.
@psychedelicious
feat(ui): simpler imageUploaded toast handling
16bff2c
@psychedelicious
tidy(ui): clean up imageUploaded listener
a0f89ee
@psychedelicious
feat(ui): updated useFullscreenDropzone
1b3f0f0 
- Hack around toast durations so it closes after last image uploads
- Improved error logging
- Enforce singleton nature of hook
@psychedelicious
feat(ui): only switch boards on first upload of an image
b946a1e
@psychedelicious
feat(ui): add maxImageUploadCount config setting
273ffd7
@psychedelicious
fix(ui): erroneous board selection when uploading multiple images
b87caef
@psychedelicious
fix(ui): race condition with toast closing
06d8a5b 
Instead of providing a duration to the upload action, we close the toast imperatively in the `imageUploaded` listener using a timeout. 3s after the last upload toast, we close it.

This handles the case when we are uploading multiple images and don't want the toast to close til it's all finished.
@psychedelicious
fix(ui): ts
78ea882
@psychedelicious psychedelicious merged commit ad1a8fb into main Oct 16, 2024
14 checks passed
@psychedelicious psychedelicious deleted the maryhipp/bulk-upload branch October 16, 2024 07:33
This was referenced Oct 16, 2024
Closed
Closed
Closed
Closed
@adoermenen adoermenen mentioned this pull request Oct 16, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryhipp @psychedelicious