-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(ui): canvas auto-mask #7163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hipsterusername
approved these changes
Oct 22, 2024
`ts-toolbelt` is unmaintained while `type-fest` is very actively maintained. Both provide similar TS utilities.
Move brush tool event logic to its class.
It's essentially a noop but I think it makes sense to have a module for each tool...
`isolatedFilteringPreview` and `isolatedTransformingPreview` are merged into `isolatedLayerPreview`. This is also used for segment anything.
Fix an issue where if the input image is transparent in a region to be masked, that transparent region ends up opaque black. Need to respect the input image transparency by applying the mask to the alpha channel only.
15a06ec
to
f73aaf5
Compare
It's used for more than filters now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
PRs that change backend files
frontend
PRs that change frontend files
frontend-deps
PRs that change frontend dependencies
invocations
PRs that change invocations
python
PRs that change python files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CanvasSegmentAnythingModule
class is similar toCanvasEntityFilterer
, but implemented separately to allow for interactions on the canvas, which would have been tricky to add toCanvasEntityFilterer
. In the future, the SAM module could be used as a blueprint for filters that need canvas interactions.isolatedFilteringPreview
andisolatedTransformingPreview
settings into a singleisolatedLayerPreview
. It is now used for auto-masking, filtering and transforming.autoProcessFilter
toautoProcess
. It is now used for auto-masking and filtering.ts-toolbelt
fortype-fest
. Was gonna use a util type from it but eventually figured a way to not need the type. Oh well, good to update the dependency anyways.Related Issues / Discussions
QA Instructions
YOLO
Merge Plan
n/a
Checklist