fix(ui): prevent canvas & main panel content from scrolling #7532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
maryhipp
approved these changes
Jan 8, 2025
Hopefully fixes issues where, when run via the launcher, the main panel kinda just scrolls out of bounds.
psychedelicious
force-pushed
the
psyche/fix/ui/scrolling-out-of-bounds
branch
from
18a7618 to
5ab75b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hopefully fixes issues where, when run via the launcher, the main panel kinda just scrolls out of bounds.
Just adding
overflow: hiddento all divs from the top level down to canvas and viewer. I did all sorts of stuff on canvas on Windows and macOS in an attempt to repro the issue but couldn't, so we'll just need to get this fix released to see if it works.Related Issues / Discussions
Multiple discord reports:
QA Instructions
Release to affected users so they can test it.
Merge Plan
n/a
Checklist