Fix: Multiply Image Channel allows RGB inputs again #7633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunkeroni
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
psychedelicious
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The alpha handling that lets image multiply work on canvas filters broke if it was downstream of certain nodes that always output RGB instead of RGBA. ImageChannelMultiply node now loads as RGBA first. I had this fix in the Offset node already, but forgot to add it to the multiply one. Oops.
Merge Plan
ready to merge
Checklist