Skip to content

workflow builder iteration 2 #7657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Feb 20, 2025

Summary

  • Give image fields a max height and show the image dimensions in a badge.
  • Make the field name the drag handle for fields. Previously it was the whole field name "bar", and it was really easy to accidentally drag a field when you wanted to drag a node.
  • Abstract out node and field validation logic (i.e. when a field is required but doesn't have value). Previously this was awkwardly duplicated.
  • Take advantage of the restructured field validation logic to make node titles error-colored when any field has is invalid (this was not possible w/ the prev code structure).
  • Fix an issue where pasting nodes/edges that include a collapsed edge failed.
  • Double-clicking a node fits it to view. Some care is required for this to not interfere with other click-activated functionality (editable titles, buttons, input fields).

Related Issues / Discussions

Offline discussion

QA Instructions

Try it out

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Feb 20, 2025
Requires a bit of fanagling to ensure the double click doesn't interfer w/ other stuff
@psychedelicious psychedelicious merged commit f77549d into main Feb 20, 2025
15 checks passed
@psychedelicious psychedelicious deleted the psyche/ui/workflow-builder-iteration-2 branch February 20, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants