fix(app): error on upload + resize for unusual image modes #8096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
hipsterusername and
jazzhaiku
as code owners
maryhipp
approved these changes
Jun 10, 2025
hipsterusername
approved these changes
Jun 11, 2025
psychedelicious
force-pushed
the
psyche/fix/app/upload-resize-to
branch
from
009c5ad to
39c70e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes HTTP 500
Failed to resize imagewhen using new canvas from image with resize functionality, on images with unusual image modes. Need to convert to RGBA first.Ideally
heuristic_resizewould handle this but this is a quicker, clearer fix.Related Issues / Discussions
n/a
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)