Skip to content

changes to spammer tool #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2021
Merged

changes to spammer tool #1854

merged 3 commits into from
Dec 20, 2021

Conversation

apenzk
Copy link
Contributor

@apenzk apenzk commented Nov 22, 2021

Description of change

updated the documentation to account for the new way of using the spammer

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Fix

How the change has been tested

Its basically just text.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@apenzk apenzk requested a review from daria305 November 22, 2021 15:19
daria305
daria305 approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@daria305 daria305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, I think line 23 is not necessary but doesn't bother too

plugins/spammer/webapi.go Outdated
request.Rate = 1
request.Unit = "mps"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if needed here, as later mps is set as default in switch anyway. Also it still can be changed to mpm if user provided it as a parameter. In log we can just say rate is set to 1 per time unit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will remove this.

@karimodm karimodm merged commit 344ecfa into develop Dec 20, 2021
@karimodm karimodm mentioned this pull request Jan 12, 2022
Merged
karimodm added a commit that referenced this pull request Jan 12, 2022
@karimodm @capossele
@piotrm50 @georgysavva @apenzk @Wollac @GalRogozinski
Release v0.8.4 (#1955)
2943b3e 
* Add length check (#1874)

* length check

* feed the dog

* fix imports

* re-fix imports

* v0.8.3 (#1890)

* Version bumps v0.8.3

* Changelog v0.8.3

* Feat/feature network (#1895)

* Feature network: Ansible code (#1844)

* Feature network

* Fixes to align to develop

* Download custom snapshot during image build. (#1857)

* Download custom snapshot during image build.

* Improve Docker build caching.

* Fix download script.

* Address review comments.

* Use different library to download from zippyshare.

* Add support for default feature network snapshot.

* Update URL of default feature network snapshot.

* Feature network GitHub action (#1860)

* Feature network

* Fixes to align to develop

* Download custom snapshot during image build.

* Add github action to deploy feature network with custom snapshot.

* Improve Docker build caching.

* Fix download script.

* Trigger workflow execution

* Trigger workflow execution manually

* Address review comments.

* Remove unnecessary lines.

* Parametrize Docker Image

* Add missing Ansible variable.

* Fix argname.

* Fix input name

* Use different library to download from zippyshare.

* Add support for default feature network snapshot.

* Add supoort for default feature network snapshot.

* Update URL of default feature network snapshot.

* Fix entrynode URL

* Update entrynode public key

* Parametrize genesis public key

* Simplify workflow parameters

* Remove extra feature-deploy.yml playbook file

Co-authored-by: Andrea Villa <[email protected]>
Co-authored-by: Georgy Savva <[email protected]>

* Remote debugging (#1894)

* Introduce Delve debugger to Dockerfile

* Add "--continue" flag to dlv binary to startup the goshimmer process right away

* Add delve debugger port to docker-compose

* Enable Remote Debugging for feature network

* Temporarily enable feature-network deployment on push

* Remove "entrypoint" statement from the docker-compose files

* Revert "Temporarily enable feature-network deployment on push"

This reverts commit 0b4c166.

* Update .github/workflows/feature-network-deploy.yml

Co-authored-by: Piotr Macek <[email protected]>
Co-authored-by: Georgy Savva <[email protected]>
Co-authored-by: Georgy Savva <[email protected]>

* Add missing prometheus.yml file and improve volumes in docker-compose files. (#1899)

* Improve integration tests. (#1906)

* Improve integration tests.

* Improve the tests

* Improve integration tests.

* Improve integration tests.

* Remove unnecesary pledge IDs

* Fix mana integration test (#1909)

* Fix mana integration test

* Loosen the condition

* Don't log errors on write to closed connection (#1915)

* Don't log errors on write to closed connection

* Gofumpt

* fix go.mod

* Fix feature network deployment. (#1925)

* Remove quotes so wget doesn't fail

* Turn off debugging

* Revert debugging.

* Add snapshotResetTime parameter for feature-network

* Make delve port customizable via ENV variable

* Switch from "host" network to bridge to resolve delve ports conflict for analysis-server and entrynode

* Revert "Make delve port customizable via ENV variable"

This reverts commit d6075bd.

* Add heuristic not to assign markers to spamming nodes.

* Remove quotes from the default snapshot URL.

* further fix mana integration test

* Fix port mapping

* Don't expose autopeering port in Dockerfile

Co-authored-by: Georgy Savva <[email protected]>

* Fix prometheus scrape ports (#1928)

* Change prometheus scrape port to 9311 for consistency. Publish that port to the host network on Goshimmer nodes

* Change ports for analysis-server

Co-authored-by: Georgy Savva <[email protected]>

* Customize PoW difficulty on feature network. (#1937)

* Update aMana update formula to fix NaN problem (#1930)

* Update aMana update formula to avoid division by zero due to rounding errors.

* Gofumpt

* Fix node identity problem after restart (#1939)

* Update hive.go and others.

* Update hive.go and others in integration tests

* Fix/feature network port forwarding problem (#1940)

* Pause Ansible deployment for 30 seconds to invalidate tracked UDP connections.

* Clear connection tracker entries before starting goshimmer

* Increase sleep duration

* Clean conntrack connections

* Ignore conntrack errors

* changes to spammer tool (#1854)

* changes to spammer tool

* remove unit setting

* Devnet AnalysisServer should use LBed dashboards WS (#1942)

* Snapshot nil pointer dereference fix (#1943)

* Remove tons of output when dumping snapshot

* Check if consumer exists to avoid nil pointer dereference

* Remove spam debug log about duplicate bytes. (#1949)

* New Scheduler buffer management & data flow (#1856)

* Initialize deficit for all nodes that have min amount of active access mana.

* Fix unit test.

* Update unit test.

* Allow scheduling messages of zero mana nodes.

* Apply suggestions from code review

Co-authored-by: Wolfgang Welz <[email protected]>

* Apply review suggestions.

* MinMana value hardcoded in scheduler instead of mana pacakge.

* sort imports

* remove nodes with less than MinMana

* remove orderer and add dispatcher

* Remove timestamp filter from parser.

* Fix division by zero error.

* Fix unit test.

* Fix integration test.

* Works now?

* Disable MinMana check in Faucet plugin

* MinMana is returned by mana plugin.

* Restore waiting for access mana in faucet plugin

* Fix integration test.

* WIP: implement drop head buffer management policy

* Make use of ready flag

* Remove Strong Parents upon confirmation

* Set ready flag upon scheduled and confirmation events

* revert TSA changes

* revert TSA comment

* fix typo

* address review comments

* Remove leftover println.

* Do not remove nodes from scheduler out of the designated function

* MinMana assigned to zero-mana nodes only in scheduler.

* Fix unit tests.

* Allow zero mana nodes to access the network.

* Skip the ValueAliasDelegation integration test.

* skip confirmed messages from being dispatched

* Refactor the drop head policy. Add access mana cache.

* Fix unit test

* Bow to the doggo

* add parentsMap

* Fix tangle time bug.

* Implement unit tests for drop-head and fix some bugs.

* Add Issue #1855 to the comments

* fix BytesRejected handler

* revert parents map

* clean up code

* Address review comments.

* Fix confirmed message removal bug.

* Remove scheduler bypass flag.

* Regenerate pkged.go

* Implement scheduler metrics and simplify existing ones.

* Update Grafana dashboard to new metrics.

* Fix details in Grafana Dashboard.

* Add overall buffer size info into /info endpoint.

* Fix concurrent map write bug

* Add solidification requests metric.

* Simplify DBStats method

* Fix unit tests

* Fix unit tests

* Fix mana integration test

* Fix doggo

* Fix node queue size metrics.

* Scheduler skips confirmed messages (#1905)

* Add missing prometheus.yml file and improve volumes in docker-compose files.

* Skip old confirmed messages in scheduler.

* Skip old (>1min) confirmed messages in the scheduler.

* Implement unit test for skipping confirmed message in the scheduler.

* Use RWMutex in scheduler.

* Parametrize confirmed message scheduling threshold.

* Improve unit tests.

* Unit test fix.

* Add heuristic not to assign markers to spamming nodes.

* Add skipped messages to dashboard.

* Update packages/tangle/booker.go

* Change prometheus scrape port to 9311 for consistency. Publish that port to the host network on Goshimmer nodes

* Change ports for analysis-server

* Enable spammer in feature network.

* Customize PoW difficulty on feature network.

* Enable all remotemetrics on deployed servers.

Co-authored-by: Georgy Savva <[email protected]>

* Feat/remote log scheduled metrics (#1900)

* add scheduled events metrics

* add dropped time event

* add mana to metrics

* fix access mana query

* add message discarded metric

* add message queued metric

* copy functions from Piotr

* add scheduler metrics

* Add missing message metrics

* fix case and imports

* logstash.conf

* Comments fixing is fun :-)

Co-authored-by: Piotrek <[email protected]>

* record time it took to schedule and process a message

* add issuer Id to missing messages

* add a mana normalized queue stat

* fix function redeclaration from merge

* remove whiteline in imports

* add more metrics

* add dot

* remove double closure

* Node state logger update moved from run

* Bugfixes and improvements

* Do not log problems with sending remotemetrics

* Skip remotemetrics when remotelog is disabled.

* Bugfixes and improvements.

* Turn off remotelog plugin for integration tests and entrnode.

* Update logstash config for new metrics.

Co-authored-by: Piotrek <[email protected]>

* Apply review suggestions.

* Apply suggestions from code review

Co-authored-by: Wolfgang Welz <[email protected]>

Co-authored-by: Wolfgang Welz <[email protected]>
Co-authored-by: capossele <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
Co-authored-by: Georgy Savva <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>

* Build and push images tagged with version number (#1950)

* Add docker image tagging with released version.

* Initiate workflow

* Revert changes

* Use testing repository

* Use devnet environment to push to official repo

* Default to automated snapshot on Docker image creation (#1953)

* Versions bump (#1954)

* Versions bump

* CHANGELOG

Co-authored-by: Angelo Capossele <[email protected]>
Co-authored-by: Piotr Macek <[email protected]>
Co-authored-by: Georgy Savva <[email protected]>
Co-authored-by: Georgy Savva <[email protected]>
Co-authored-by: Andreas Penzkofer <[email protected]>
Co-authored-by: Wolfgang Welz <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
@karimodm karimodm deleted the fix/spammerToolDescription branch February 24, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karimodm karimodm karimodm approved these changes

@daria305 daria305 daria305 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apenzk @karimodm @daria305