Add issuerID to remote metrics #2042
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,3 +1,3 @@ | |||
| ELK_VERSION=7.5.2 | |||
| ELK_VERSION=7.13.2 | |||
There was a problem hiding this comment.
There's already 8.0.0, no?
I usually recommend doing those changes in a seperate PR (assuming ansible creates a .env file from this template). This is because it is considered a bad practice to hide version upgradings inside PRs.
If someone tries to query elastic and get different behavior looking at git log won't tell him a thing...
Also if for some reason we understand that upgrading ELK is bad git revert won't work.
I guess in this project we less care about this stuff and I am not the repo maintainer, so I will simply approve and you can choose what you want to do with this comment :-)
There was a problem hiding this comment.
This is only for local deployment only. The version deployed by ansible is 7.13.2 already so it's more of a cosmetic change.
* add socat container * initialize socat containers * Pull socat image * Fix: redirection using socat works * Pull socat image in github integration tests workflow * Pull socat image in github workflow * Stop and remove socat containers when network shutdowns * expose dashboard * no socat for entry node * Add issuerID to remote metrics (#2042) * Add issuerID metric to remote metrics. * Update local ELK stack version. * Refactor: gofmt IssuerID Co-authored-by: Andrea V <[email protected]> * close socat containers quickly and hide errors * bind Dag visualizer * add comment * fix capitalization issue * kiil socat containers Co-authored-by: Gal Rogozinski <[email protected]> Co-authored-by: jkrvivian <[email protected]> Co-authored-by: Piotrek <[email protected]>
Description of change
Add issuerID to remote metrics
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.