Skip to content

Fix: several bugs in Notarization and Networking #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 1, 2022
Merged

Fix: several bugs in Notarization and Networking #2412

merged 13 commits into from
Sep 1, 2022

Conversation

karimodm
Copy link
Contributor

@karimodm karimodm commented Sep 1, 2022

Description of change

Fixes:

  • epochProcessBlockCommand: index out of range [0] with length 0.
  • p2p concurrent map write.
  • objectstoreage creation leak from mana_plugin.
  • tentative fix: readloop still seems to consume too much CPU (maybe still in an endless loop?).
  • implemented shrinkingnmaps in notarization manager.

@karimodm karimodm requested a review from jonastheis September 1, 2022 12:22
jonastheis
jonastheis approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@jonastheis jonastheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice bunch of fixes

@karimodm karimodm temporarily deployed to feature September 1, 2022 13:45 Inactive
@karimodm karimodm temporarily deployed to feature September 1, 2022 13:57 Inactive
@karimodm karimodm merged commit 27b9657 into develop Sep 1, 2022
@karimodm karimodm deleted the fix/release-bugs branch September 1, 2022 14:11
This was referenced Sep 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonastheis jonastheis jonastheis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karimodm @jonastheis