-
Notifications
You must be signed in to change notification settings - Fork 69
feat: improve helia 101 example #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@achingbrain When running the new 401 example my node hangs indefinitely when calling helia-examples/examples/helia-101/401-providing.js Lines 57 to 77 in aa5b910
I'm not too familiar with the Update 19.3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of comments inline.
Co-authored-by: Alex Potsides <[email protected]>
What
Additions for a followup
TODO
'/ip4/0.0.0.0/udp/0/webrtc-direct'
libp2p/js-libp2p#3049) no longer relevant since we only create one node and