-
Notifications
You must be signed in to change notification settings - Fork 15
Add dag-scope tests #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding related contributors for review, the code looks fine to me; |
Had trouble doing a clean rebase so force pushed instead 😅 |
The tests haven't been running on this PR because we had a wrong trigger configured for the job. This is being fixed in #60 In the meantime, I pushed https://github.com/ipfs/gateway-conformance/tree/guanzo-main so that we get CI runs for the HEAD of this PR. Unfortunately, it looks like the newly added tests aren't passing when running against kubo-master. See https://github.com/ipfs/gateway-conformance/actions/runs/5119205028/attempts/1#summary-13852714693 |
The failures are due to kubo not "returning intermediate blocks from the CID root to the path terminus as part of the returned CAR file" as mentioned in this PR. ipfs/specs#402. Not sure how we want to proceed as idk when kubo will implement that. |
We can skip the some expects like this:
|
* add test for missing dag-scope parameter
I can skip the CAR cid checks but that basically skips all tests added by this PR 😆 . We can do that or skip the intermediate cid checks for now. |
TODO:
car-scope
todag-scope
once lassie supports it.How I generated the fixture
The point of 2 subdirectories is that if the request is for one of them (
/sub1/hello.txt
), than the other (/sub2
) should not appear in the CAR.