Skip to content

fix: remove countly #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2025
Merged

fix: remove countly #1327

merged 5 commits into from
Feb 28, 2025

Conversation

2color
Copy link
Member

@2color 2color commented Feb 27, 2025

Summary

This PR removes all Countly tracking functionality from the project while preserving user preferences and maintaining a consistent UI (in case we want to add back a different implementation) . The telemetry collection has been completely disabled, with tracking functions replaced by no-op implementations that only log debug messages.

Fixes #1315
Closes #1141

Changes

  • Replaced tracking functions with no-op implementations that only log debug messages
  • Preserved original storage keys for backward compatibility with existing user preferences
  • Updated the telemetry UI to clearly indicate that tracking has been removed
  • Maintained the telemetry toggle in UI
  • Updated documentation to reflect the removal of telemetry
  • Removed custom Countly type definitions
  • Removed the @ipfs-shipyard/ignite-metrics dependency

@2color 2color requested review from lidel, whizzzkid and a team as code owners February 27, 2025 13:24

This comment was marked as resolved.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only comment here is that we should probably hide (keep code, but remove the UI visibility) of the toggle tracking UI, otherwise the code changes LGTM.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good idea about hiding telemetry section, pushed a fix.

if looks fine, feel free to merge, then we can ship this to see how long chrome web store publishing takes

@SgtPooki do you still have permissions, or should I do the release?
I think @2color does not have account for that yet

@2color
Copy link
Member Author

2color commented Feb 28, 2025

Can confirm this is working including the hiding of the telemetry section. Thanks @lidel

@2color 2color merged commit 70790a3 into main Feb 28, 2025
5 checks passed
@2color 2color deleted the remove-countly branch February 28, 2025 09:37
@SgtPooki
Copy link
Member

@SgtPooki do you still have permissions, or should I do the release?

I believe I have permissions. I can start release this monday unless you want me to try to start it today? If started today it would likely be out in FF/chrome tomorrow through tuesday.

@lidel
Copy link
Member

lidel commented Feb 28, 2025

Let's not ship on Friday, Monday is fine :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove countly.ipfs.tech telemetry Telemetry: click count per menu option
3 participants