-
Notifications
You must be signed in to change notification settings - Fork 325
fix: remove countly #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove countly #1327
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only comment here is that we should probably hide (keep code, but remove the UI visibility) of the toggle tracking UI, otherwise the code changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this is working including the hiding of the telemetry section. Thanks @lidel |
I believe I have permissions. I can start release this monday unless you want me to try to start it today? If started today it would likely be out in FF/chrome tomorrow through tuesday. |
Let's not ship on Friday, Monday is fine :) 👍 |
Summary
This PR removes all Countly tracking functionality from the project while preserving user preferences and maintaining a consistent UI (in case we want to add back a different implementation) . The telemetry collection has been completely disabled, with tracking functions replaced by no-op implementations that only log debug messages.
Fixes #1315
Closes #1141
Changes