-
Notifications
You must be signed in to change notification settings - Fork 511
fixed all eslint warnings in root #2378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
@SgtPooki any chance you could provide feedback or a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some CI is failing
Thanks for running CI, I did not expect to find new warnings. Fixing newly found errors. |
Excuse me for being annoying @SgtPooki. I have run |
🤣 no worries, thanks for opening an issue and submitting a fix for it! not a problem at all.. clicking "run CI jobs" is the easiest thing I've done today 😛 |
#2377