BroadcastView scheduler implementation #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple commits.
- ensure broadcast scheduler has an identity set - make default no setting of identity (avoids collision when unset)
broadcast fixes from today
- works now because msg_id of msg is correctly replaced in scheduler
use traitlets config to expose HubFactory.broadcast_scheduler_depth
parse on request in metadata now that they aren't parsed on receiving messages anymore
|
Still lots of docs and testing to do, but this is working well and existing tests are passing. Great job @tomoboy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains work done as part of my master thesis on how to scale parallelism in IPython Parallel. It's still a work in progress as it needs some clean up, documentation and tests etc. I'm planning to do all that before I request any reviews, but I want to open the PR now so that I can state in my thesis that the work has been submitted.