-
Notifications
You must be signed in to change notification settings - Fork 46
add noble address to RakoffRelayer #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new address mapping has been added to the Changes
Sequence Diagram(s)Not applicable: The change is a static data update and does not affect control flow or introduce new features requiring a sequence diagram. Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
relayers/RakoffToken/relayer_info.json (1)
32-36
: New noble-1 address mapping looks goodThe added object correctly pairs
"columbus-5"
with the"noble-1"
address, and the comma placement and indentation align with the existing entries.Consider alphabetically ordering the
addresses
array by the target network key to simplify lookups and reduce merge conflicts going forward.
this might fix #78 - not completely sure about that.
Summary by CodeRabbit