R4R: Fix issue663 #671
Merged
R4R: Fix issue663 #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push code from develop to master
irishub introduction
|
Excellent！ |
MrXJC
reviewed
Nov 20, 2018
| keys = append(keys, string(kv.Key)) | ||
| } | ||
| if keyStr != "" { | ||
| iparam.RegisterGovParamMapping(&govparams.DepositProcedureParameter, |
There was a problem hiding this comment.
You could add the service GovParameter. It will be better.
| } | ||
| } | ||
|
|
||
| // Check --key parameter if the --module parameter is empty. | ||
| if keyStr != "" { | ||
| iparam.RegisterGovParamMapping(&govparams.DepositProcedureParameter, |
There was a problem hiding this comment.
The comment is same as the above.
MrXJC
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#663
my testcases the following:
➜ ~ iriscli gov query-params --module=gov1
ERROR: ERROR:
Codespace: 6
Code: 113
Message: "The GovParameter of the module gov1 is not existed"
➜ ~ iriscli gov query-params --module=gov1 --key=Gov/govTallyingProcedure
ERROR: ERROR:
Codespace: 6
Code: 113
Message: "The GovParameter of the module gov1 is not existed"
➜ ~ iriscli gov query-params --module=gov1 --key=Gov/govTallyingProcedure1
ERROR: ERROR:
Codespace: 6
Code: 113
Message: "The GovParameter of the module gov1 is not existed"
➜ ~ iriscli gov query-params --key=Gov/govTallyingProcedure1
ERROR: ERROR:
Codespace: 6
Code: 111
Message: "Gov/govTallyingProcedure1 is not found"
➜ ~ iriscli gov query-params --module=gov --key=Gov/govTallyingProcedure1
ERROR: ERROR:
Codespace: 6
Code: 111
Message: "Gov/govTallyingProcedure1 is not found"
➜ ~ iriscli gov query-params --module=gov
[
"Gov/govDepositProcedure",
"Gov/govTallyingProcedure",
"Gov/govVotingProcedure"
]
➜ ~ iriscli gov query-params --key=Gov/govTallyingProcedure
{"key":"Gov/govTallyingProcedure","value":"{"threshold":"0.5000000000","veto":"0.3340000000","participation":"0.6670000000"}","op":""}
➜ ~ iriscli gov query-params --module=gov --key=Gov/govTallyingProcedure
{"key":"Gov/govTallyingProcedure","value":"{"threshold":"0.5000000000","veto":"0.3340000000","participation":"0.6670000000"}","op":""}