fix nothing #18843
fix nothing #18843
Conversation
WalkthroughThis change introduces the initial setup for a new Nx-managed Next.js application named Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant NextJS_Server
participant ApolloClient
participant GraphQLEndpoint
Browser->>NextJS_Server: Request page (e.g., /[lang]/about)
NextJS_Server->>ApolloClient: Initialize with SSR cache (if any)
NextJS_Server->>GraphQLEndpoint: (If needed) Fetch data via Apollo
GraphQLEndpoint-->>NextJS_Server: Return GraphQL data
NextJS_Server->>Browser: Rendered HTML + initial Apollo state
Browser->>ApolloClient: Hydrate with initial state
Browser->>GraphQLEndpoint: (On client navigation) Fetch data via Apollo
GraphQLEndpoint-->>Browser: Return GraphQL data
sequenceDiagram
participant Developer
participant Nx_CLI
participant NextJS_Server
participant CustomServer
Developer->>Nx_CLI: Run build/serve/test/lint/export
Nx_CLI->>NextJS_Server: Build or start Next.js app (with plugins/config)
Nx_CLI->>CustomServer: Build or start custom server (if configured)
Nx_CLI->>Nx_CLI: Run lint/test/extract-strings as per configuration
sequenceDiagram
participant User
participant NextJS_App
participant Localization
participant ApolloProvider
User->>NextJS_App: Navigate to page
NextJS_App->>Localization: Get locale, messages, formatters
NextJS_App->>ApolloProvider: Provide GraphQL client context
NextJS_App->>User: Render localized UI with data
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
🧹 Nitpick comments (24)
apps/hackathon-phi/pages/index.tsx (1)
1-4: Page entrypoint correctly re-exports the Home component
This minimal page file follows Next.js routing conventions.
Optional: For stronger type safety, you could explicitly importNextPagefrom'next'and annotate this export accordingly.apps/hackathon-phi/pages/[lang]/about.tsx (1)
1-3: Dynamic language route correctly re-exports About component
This file adheres to Next.js dynamic routing patterns.
Optional: Add aNextPagetype annotation for theAboutcomponent to improve type clarity.apps/hackathon-phi/README.md (1)
5-5: Fix grammatical error in README.
Change "too tackle" to "to tackle" for clarity.Proposed diff:
-The idea of this app is too tackle the possible hackathon solution. +The idea of this app is to tackle the possible hackathon solution.🧰 Tools
🪛 LanguageTool
[uncategorized] ~5-~5: “too” (as well, very, ‘too much’) seems less likely than “to”.
Context: ...thon ## About The idea of this app is too tackle the possible hackathon solution....(AI_HYDRA_LEO_CP_TOO_TO)
apps/hackathon-phi/index.d.ts (1)
1-5: Refine SVG module typings for type safety.
Usinganyis permissive; consider specifying proper React SVG types. For example:-declare module '*.svg' { - const content: any - export const ReactComponent: any - export default content -} +declare module '*.svg' { + import * as React from 'react'; + export const ReactComponent: React.FunctionComponent<React.SVGProps<SVGSVGElement>>; + const src: string; + export default src; +}This provides stronger typing when importing SVGs as components or URLs.
apps/hackathon-phi/tsconfig.server.json (2)
2-9: Ensure clarity of incremental build info file path
ThetsBuildInfoFileis set to"../../tmp/buildcache/apps/hackathon-phi/server"without a.tsbuildinfoextension. For consistency and easier debugging, consider giving it a clear file name with the.tsbuildinfoextension (e.g."../../tmp/buildcache/apps/hackathon-phi/server.tsbuildinfo").
10-11: Scope your include patterns for future growth
Right now onlyserver.tsis compiled. If you add helper modules or split server logic into subfolders, you’ll need to update this. You might preemptively widen the pattern (e.g."src/**/*.ts") or include aserver/directory.apps/hackathon-phi/environments/environment.ts (1)
1-10: Leverage Next.js built‑in environment support and add typings
Next.js already injectsprocess.env.*into the client vianext.config.js(usingenvorpublicRuntimeConfig). Maintaining a separateenvironment.tscan lead to duplication. Consider dropping this file in favor of Next.js’s.env.localorpublicRuntimeConfigpatterns.Additionally, for better type safety, define an interface:
interface EnvironmentConfig { production: boolean } const config: EnvironmentConfig = /* … */ export default configapps/hackathon-phi/server.ts (1)
3-10: Add typing and runtime‑safe fallback forgraphqlEndpoint
TheexternalEndpointDependenciescallback currently treatsnextConfigas untyped and destructuresgraphqlEndpointwithout a check. To prevent runtime errors, declare the parameter type (e.g.(nextConfig: { serverRuntimeConfig: { graphqlEndpoint?: string } })) and either provide a default or throw an error ifgraphqlEndpointis missing.apps/hackathon-phi/tsconfig.json (1)
13-15: Consider specifying include patterns.The configuration currently has empty
includeandfilesarrays, relying solely on referenced configs. Adding explicit include patterns would make it clearer which files are included in the compilation.- "include": [], + "include": ["**/*.ts", "**/*.tsx"], "exclude": ["node_modules"], - "files": [],apps/hackathon-phi/.eslintrc.json (2)
3-3: Clarify ignorePatterns configuration.The pattern
"!**/*"uses a double negative which means "don't ignore any files". While this is valid, it can be confusing. Consider adding a comment to explain this behavior for future developers.- "ignorePatterns": ["!**/*"], + "ignorePatterns": ["!**/*"], /* Don't ignore any files - required for proper linting */
5-9: Consider adding project-specific linting rules.The configuration currently has empty rule sets. Consider adding project-specific rules to enforce consistent coding standards for the hackathon application.
- "rules": {}, + "rules": { + "react/react-in-jsx-scope": "off" // React 17+ doesn't require importing React + }, "overrides": [ - { "files": ["*.ts", "*.tsx", "*.js", "*.jsx"], "rules": {} }, - { "files": ["*.ts", "*.tsx"], "rules": {} }, - { "files": ["*.js", "*.jsx"], "rules": {} } + { "files": ["*.ts", "*.tsx", "*.js", "*.jsx"], "rules": {} }, + { "files": ["*.ts", "*.tsx"], "rules": { + "@typescript-eslint/explicit-function-return-type": ["warn", { "allowExpressions": true }] + } }, + { "files": ["*.js", "*.jsx"], "rules": {} }apps/hackathon-phi/next.config.js (2)
27-29: Document the purpose of API_MOCKS environment variable.The
API_MOCKSenvironment variable is passed to the Next.js environment but its purpose isn't documented. Add comments to clarify how this variable should be used.env: { - API_MOCKS: process.env.API_MOCKS ?? '', + // When set, enables mock API responses for development and testing + API_MOCKS: process.env.API_MOCKS ?? '', },
13-18: Consider enabling source maps for client-side production builds for error tracking.Source maps are only enabled for server-side production builds. Consider enabling them for client-side production builds as well to improve error tracking in production.
webpack: (config, { isServer, dev }) => { - if (!dev && isServer) { + // Enable source maps in production for both client and server + if (!dev) { config.devtool = 'source-map' } return config },apps/hackathon-phi/jest.config.ts (2)
1-1: Use more specific ESLint disable comments.The broad ESLint disable comment at the top of the file could be replaced with more specific ones targeting only the necessary rules.
-/* eslint-disable */ +/* eslint-disable @typescript-eslint/no-explicit-any */
13-15: Set coverage thresholds to maintain code quality.The configuration doesn't define coverage thresholds. Adding them would help maintain code quality by ensuring sufficient test coverage.
moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'html'], coverageDirectory: '<rootDir>/coverage/apps/hackathon-phi', + coverageThreshold: { + global: { + branches: 70, + functions: 70, + lines: 70, + statements: 70 + } + }, globals: {},apps/hackathon-phi/pages/_document.tsx (2)
5-7: Add validation for supported languages.Consider adding validation to ensure the language is one of the supported languages for your application.
+import { defaultLanguage, supportedLanguages } from '@island.is/shared/constants' + interface Props { - lang: string + lang: string; + // Add other document props if needed }And in the getInitialProps method:
- return { ...initialProps, lang: ctx?.query?.lang ?? defaultLanguage } + const requestedLang = ctx?.query?.lang as string | undefined; + const validLang = requestedLang && supportedLanguages.includes(requestedLang) + ? requestedLang + : defaultLanguage; + return { ...initialProps, lang: validLang }Assuming
supportedLanguagesis exported from the constants file. If not, you'll need to create it.
19-27: Add support for RTL languages if needed.If your application needs to support RTL (right-to-left) languages like Arabic or Hebrew, consider adding the
dirattribute to the HTML element.+ // List of RTL languages + const rtlLanguages = ['ar', 'he', 'fa']; + const isRtl = rtlLanguages.includes(lang); + return ( - <Html lang={lang}> + <Html lang={lang} dir={isRtl ? 'rtl' : 'ltr'}> <Head /> <body> <Main />apps/hackathon-phi/pages/_app.tsx (1)
9-18: Add TypeScript return type to Layout componentThe Layout component would benefit from an explicit return type for better type safety.
-const Layout: FC<React.PropsWithChildren<unknown>> = ({ children }) => { +const Layout: FC<React.PropsWithChildren<unknown>> = ({ children }): JSX.Element => {apps/hackathon-phi/screens/Home.tsx (2)
18-84: Add TypeScript return type and improve component structureThe component should have proper TypeScript typing and could be better structured.
-const Home = () => { +const Home = (): JSX.Element => { const { lang, formatDate, formatTime, formatMessage } = useLocale() - console.log('__intl formatMessage__', formatMessage) return ( <div> <Page> <Box padding="containerGutter"> <Header /> </Box> + <StringsSection formatMessage={formatMessage} /> + <DateTimeSection formatDate={formatDate} formatTime={formatTime} /> + <NavigationSection lang={lang} /> + </Page> + </div> + ) +} + +const StringsSection = ({ formatMessage }) => ( <Box padding="containerGutter"> <h2>Strings</h2> <FormattedMessage id="reference:title" // namespace:messageId description="This is a title in the reference namespace" defaultMessage="Island.is" /> <p> {formatMessage({ id: 'reference:description', description: 'This is a description in the reference namespace', defaultMessage: 'Lýsing', })} </p> <p> {formatMessage(welcomeMessage, { name: 'Foo', })} </p> <p> <FormattedMessage {...welcomeMessage} values={{ name: 'Bar' }} /> </p> </Box> +) + +const DateTimeSection = ({ formatDate, formatTime }) => ( + <> <Divider /> <Box padding="containerGutter"> <h2>Dates</h2> <span title={formatDate(new Date())}> <FormattedDate value={new Date()} /> </span> </Box> <Divider /> <Box padding="containerGutter"> <h2>Time</h2> <span title={formatTime(new Date())}> <FormattedTime value={new Date()} /> </span> </Box> + </> +) + +const NavigationSection = ({ lang }) => ( <Box padding="containerGutter"> <p> <Link href="/[lang]/about" as={`/${lang}/about`}> About page </Link> </p> <p> <Link href="/[lang]" as={`/${lang === 'en' ? 'is' : 'en'}`}> {lang === 'en' ? 'Icelandic' : 'English'} </Link> </p> </Box> - </Page> - </div> - )
71-79: Improve language switcher implementationThe language switcher could be implemented more semantically with proper aria labeling.
<p> - <Link href="/[lang]" as={`/${lang === 'en' ? 'is' : 'en'}`}> + <Link + href="/[lang]" + as={`/${lang === 'en' ? 'is' : 'en'}`} + aria-label={`Switch to ${lang === 'en' ? 'Icelandic' : 'English'} language`} + > {lang === 'en' ? 'Icelandic' : 'English'} </Link> </p>apps/hackathon-phi/project.json (4)
1-7: Validate project metadata and tags
You’ve set up the project schema, sourceRoot, and tags. Consider adding more descriptive tags (e.g.,scope:hackathon-phi,type:application) to enable clearer lint rules and dependency constraints across your Nx workspace.
24-44: Tune the webpack custom-server build options
You’ve explicitly set"maxWorkers": 2, which may underutilize available CPU cores during a production build. Consider removing this setting (allow Nx to choose optimal workers) or dynamically adjusting it based on machine capacity. Also confirm whether you need to copy any staticassets(e.g., public files) into your server bundle—currently theassetsarray is empty.
88-90: Specify lint file patterns
Thelinttarget uses@nx/eslint:lintbut doesn’t specifylintFilePatterns. To avoid linting unrelated files and improve caching, consider adding:"options": { "lintFilePatterns": ["apps/hackathon-phi/**/*.{ts,tsx,js,jsx}"] }
98-103: Optimize extraction command for localization
Theextract-stringstarget invokes your TS‑Node script vianx:run-commands. Consider:
- Declaring an
outputsarray (e.g., paths to your extracted JSON) for caching.- Ensuring the command runs from the workspace root by adding a
cwdoption if needed.
Example:"outputs": ["{workspaceRoot}/i18n/extracted/hackathon-phi.json"]
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (25)
apps/hackathon-phi/.babelrc(1 hunks)apps/hackathon-phi/.eslintrc.json(1 hunks)apps/hackathon-phi/README.md(1 hunks)apps/hackathon-phi/environments/environment.ts(1 hunks)apps/hackathon-phi/graphql/client.ts(1 hunks)apps/hackathon-phi/graphql/index.ts(1 hunks)apps/hackathon-phi/index.d.ts(1 hunks)apps/hackathon-phi/jest.config.ts(1 hunks)apps/hackathon-phi/next-env.d.ts(1 hunks)apps/hackathon-phi/next.config.js(1 hunks)apps/hackathon-phi/pages/[lang]/about.tsx(1 hunks)apps/hackathon-phi/pages/[lang]/index.tsx(1 hunks)apps/hackathon-phi/pages/_app.tsx(1 hunks)apps/hackathon-phi/pages/_document.tsx(1 hunks)apps/hackathon-phi/pages/index.tsx(1 hunks)apps/hackathon-phi/project.json(1 hunks)apps/hackathon-phi/screens/About.tsx(1 hunks)apps/hackathon-phi/screens/Home.tsx(1 hunks)apps/hackathon-phi/screens/index.tsx(1 hunks)apps/hackathon-phi/server.ts(1 hunks)apps/hackathon-phi/tsconfig.app.json(1 hunks)apps/hackathon-phi/tsconfig.json(1 hunks)apps/hackathon-phi/tsconfig.server.json(1 hunks)apps/hackathon-phi/tsconfig.spec.json(1 hunks)apps/hackathon-phi/webpack.config.js(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`apps/**/*`: "Confirm that the code adheres to the following: - NextJS best practices, including file structure, API routes, and static generation methods. - Efficient state manage...
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/hackathon-phi/pages/[lang]/about.tsxapps/hackathon-phi/graphql/index.tsapps/hackathon-phi/next-env.d.tsapps/hackathon-phi/tsconfig.server.jsonapps/hackathon-phi/README.mdapps/hackathon-phi/server.tsapps/hackathon-phi/pages/index.tsxapps/hackathon-phi/tsconfig.app.jsonapps/hackathon-phi/index.d.tsapps/hackathon-phi/environments/environment.tsapps/hackathon-phi/pages/[lang]/index.tsxapps/hackathon-phi/pages/_document.tsxapps/hackathon-phi/tsconfig.jsonapps/hackathon-phi/screens/index.tsxapps/hackathon-phi/webpack.config.jsapps/hackathon-phi/pages/_app.tsxapps/hackathon-phi/jest.config.tsapps/hackathon-phi/next.config.jsapps/hackathon-phi/tsconfig.spec.jsonapps/hackathon-phi/screens/Home.tsxapps/hackathon-phi/graphql/client.tsapps/hackathon-phi/screens/About.tsxapps/hackathon-phi/project.json
🧬 Code Graph Analysis (4)
apps/hackathon-phi/server.ts (1)
apps/hackathon-phi/next.config.js (1)
nextConfig(12-30)
apps/hackathon-phi/environments/environment.ts (1)
apps/hackathon-phi/next.config.js (1)
process(5-5)
apps/hackathon-phi/webpack.config.js (1)
apps/hackathon-phi/next.config.js (2)
require(1-1)require(2-2)
apps/hackathon-phi/next.config.js (1)
apps/hackathon-phi/webpack.config.js (1)
require(1-1)
🪛 LanguageTool
apps/hackathon-phi/README.md
[uncategorized] ~5-~5: “too” (as well, very, ‘too much’) seems less likely than “to”.
Context: ...thon ## About The idea of this app is too tackle the possible hackathon solution....
(AI_HYDRA_LEO_CP_TOO_TO)
🔇 Additional comments (16)
apps/hackathon-phi/webpack.config.js (1)
1-8: Configuration is correct for Nx Webpack plugin usage
This setup properly composes thewithNxplugin into your Webpack configuration. Ensure that yourproject.jsonbuild target references this file (webpack.config.js) so that the custom server build picks it up as intended.apps/hackathon-phi/.babelrc (1)
1-4: Babel presets are correctly configured
Using@nx/next/babeltogether with your shared web preset ensures consistent transpilation across the monorepo. No additional plugins are needed at this stage.apps/hackathon-phi/graphql/index.ts (1)
1-1: GraphQL client export is properly centralized
Re-exporting the default client from./clientprovides a clear entry point for your Apollo setup.apps/hackathon-phi/next-env.d.ts (1)
1-5: Approve autogenerated Next.js type declarations.
These reference directives correctly ensure Next.js and image type support across the application. No edits are necessary, as indicated by the internal comment.apps/hackathon-phi/pages/[lang]/index.tsx (1)
1-3: Verify dynamic route data fetching strategy.
This[lang]page exportsHomedirectly but lacksgetStaticPathsorgetServerSideProps. Without one of these, Next.js cannot generate or serve dynamic locale routes as intended. Please confirm your approach—static generation with defined paths or server-side rendering—and implement the appropriate data-fetching method.apps/hackathon-phi/screens/index.tsx (1)
1-2: Barrel export looks good.
This file cleanly re-exports theHomeandAboutcomponents, simplifying imports elsewhere. No changes needed.apps/hackathon-phi/tsconfig.app.json (2)
2-6: Verify strict type‑checking and JSX settings
This file inherits from the basetsconfig.json. Please confirm that the base config enables"strict": true(and related strict flags) to enforce robust type safety in your app. Also ensure that the JSX setting (implicit or inherited) aligns with Next.js’s expectations (often"jsx": "preserve").
7-15: Exclude test files and include app sources correctly
Your exclude patterns for spec/test files andjest.config.tsare spot on, and including**/*.ts,**/*.tsx, plusnext-env.d.tscovers the app code. This setup follows Next.js conventions.apps/hackathon-phi/server.ts (1)
1-2: Verify@island.is/infra-next-serveris declared in dependencies
Ensure that the@island.is/infra-next-serverpackage is listed underdependencies(not just devDependencies) in yourpackage.json. Otherwise, the custom server bootstrap may fail at runtime.apps/hackathon-phi/tsconfig.spec.json (2)
2-8: Confirm test compiler settings and coverage directory alignment
You set"module": "commonjs"and"jsx": "react", which is correct for Jest. Please verify thatoutDir(../../dist/out-tsc) aligns with your Jest coverage output configuration so source maps resolve correctly.
9-21: Include comprehensive test file patterns
Your include block covers.spec.ts,.test.ts, TSX, JSX, JS, and the Jest config. This exhaustive pattern ensures all test files are compiled.apps/hackathon-phi/project.json (5)
9-23: Review build target dependencies
Thebuildtarget declaresdependsOn: ["build-custom-server"], which runs your custom‐server bundle before the Next.js build. Verify that your server bundle doesn’t require runtime artifacts from the.nextfolder at build time. If you do need.nextassets available when bundling, consider inverting this dependency or moving the dependency declaration into thebuild-custom-servertarget.
46-65: Approve Next.js serve configuration
Theservetarget correctly uses@nx/next:serverwith separate development and production configurations, specifyingdev,buildTarget, andcustomServerTarget. This aligns with Nx best practices for serving a Next.js app alongside a custom server.
67-81: Verify custom server executor
You’re using@nx/js:nodeas the executor to run your bundled server. Ensure this executor exists in your workspace’s Nx version (it may also appear as@nrwl/js:nodeor@nx/node:executein different plugin releases). If it errors at runtime, switch to the executor name supported by your installed Nx plugins.
82-87: Approve static export target
Theexporttarget correctly leverages@nx/next:exportto pre-render your application against the production build. You may optionally add anoutputsdeclaration for caching, but the current setup is valid out of the box.
91-97: Approve Jest test target
Yourtesttarget is configured correctly with@nx/jest:jest, points to yourjest.config.ts, and declares coverage outputs. This follows Nx recommendations for caching and isolation.
| "compilerOptions": { | ||
| "jsx": "preserve", | ||
| "allowJs": true, | ||
| "strict": false, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enable strict type checking for improved code quality.
Setting "strict": false disables TypeScript's strict type checking, which is generally not recommended for new applications. Enabling strict mode helps catch type-related bugs early and improves code maintainability.
- "strict": false,
+ "strict": true,📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "strict": false, | |
| "strict": true, |
| const { createVanillaExtractPlugin } = require('@vanilla-extract/next-plugin') | ||
| const withVanillaExtract = createVanillaExtractPlugin() | ||
|
|
||
| const { INTERNAL_API_URL = 'http://localhost:4444' } = process.env |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Validate environment variables and document fallbacks.
The configuration uses an environment variable with a hardcoded fallback. Consider adding validation for the environment variable and documenting its purpose and expected format.
-const { INTERNAL_API_URL = 'http://localhost:4444' } = process.env
+// The internal API URL for GraphQL services
+const INTERNAL_API_URL = process.env.INTERNAL_API_URL || 'http://localhost:4444'
+
+// Validate the URL format
+if (!/^https?:\/\//.test(INTERNAL_API_URL)) {
+ console.warn(`INTERNAL_API_URL should be a valid URL. Got: ${INTERNAL_API_URL}`)
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const { INTERNAL_API_URL = 'http://localhost:4444' } = process.env | |
| // The internal API URL for GraphQL services | |
| const INTERNAL_API_URL = process.env.INTERNAL_API_URL || 'http://localhost:4444' | |
| // Validate the URL format | |
| if (!/^https?:\/\//.test(INTERNAL_API_URL)) { | |
| console.warn(`INTERNAL_API_URL should be a valid URL. Got: ${INTERNAL_API_URL}`) | |
| } |
| static async getInitialProps(ctx) { | ||
| const initialProps = await Document.getInitialProps(ctx) | ||
|
|
||
| return { ...initialProps, lang: ctx?.query?.lang ?? defaultLanguage } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add proper TypeScript typing for the context parameter.
The getInitialProps method is missing proper TypeScript typing for the context parameter, which could lead to type-related issues.
- static async getInitialProps(ctx) {
+ static async getInitialProps(ctx: DocumentContext) {
const initialProps = await Document.getInitialProps(ctx)
- return { ...initialProps, lang: ctx?.query?.lang ?? defaultLanguage }
+ // Extract and validate language from query parameters
+ const queryLang = typeof ctx.query?.lang === 'string' ? ctx.query.lang : defaultLanguage
+ return { ...initialProps, lang: queryLang }
}Don't forget to import the DocumentContext type:
-import Document, { Html, Head, Main, NextScript } from 'next/document'
+import Document, { Html, Head, Main, NextScript, DocumentContext } from 'next/document'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| static async getInitialProps(ctx) { | |
| const initialProps = await Document.getInitialProps(ctx) | |
| return { ...initialProps, lang: ctx?.query?.lang ?? defaultLanguage } | |
| } | |
| // apps/hackathon-phi/pages/_document.tsx | |
| import Document, { Html, Head, Main, NextScript, DocumentContext } from 'next/document' | |
| import { defaultLanguage } from '../lib/constants' // assume this is where defaultLanguage lives | |
| class MyDocument extends Document { | |
| static async getInitialProps(ctx: DocumentContext) { | |
| const initialProps = await Document.getInitialProps(ctx) | |
| // Extract and validate language from query parameters | |
| const queryLang = typeof ctx.query?.lang === 'string' ? ctx.query.lang : defaultLanguage | |
| return { ...initialProps, lang: queryLang } | |
| } | |
| render() { | |
| return ( | |
| <Html lang={this.props.lang}> | |
| <Head /> | |
| <body> | |
| <Main /> | |
| <NextScript /> | |
| </body> | |
| </Html> | |
| ) | |
| } | |
| } | |
| export default MyDocument |
| const SupportApplication: any = ({ Component, pageProps }) => { | ||
| return ( | ||
| <ApolloProvider client={initApollo(pageProps.apolloState)}> | ||
| <Layout> | ||
| <Component {...pageProps} /> | ||
| </Layout> | ||
| </ApolloProvider> | ||
| ) | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve TypeScript typing for the SupportApplication component
The component is currently typed as any, which bypasses TypeScript's type checking benefits. This is a missed opportunity for type safety.
-const SupportApplication: any = ({ Component, pageProps }) => {
+import { AppProps } from 'next/app'
+
+const SupportApplication = ({ Component, pageProps }: AppProps) => {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const SupportApplication: any = ({ Component, pageProps }) => { | |
| return ( | |
| <ApolloProvider client={initApollo(pageProps.apolloState)}> | |
| <Layout> | |
| <Component {...pageProps} /> | |
| </Layout> | |
| </ApolloProvider> | |
| ) | |
| } | |
| import { AppProps } from 'next/app' | |
| const SupportApplication = ({ Component, pageProps }: AppProps) => { | |
| return ( | |
| <ApolloProvider client={initApollo(pageProps.apolloState)}> | |
| <Layout> | |
| <Component {...pageProps} /> | |
| </Layout> | |
| </ApolloProvider> | |
| ) | |
| } |
| SupportApplication.getInitialProps = async (appContext) => { | ||
| const { Component, ctx } = appContext | ||
| const apolloClient = initApollo({}) | ||
| const customContext = { | ||
| ...ctx, | ||
| apolloClient, | ||
| } | ||
| const pageProps = (await Component.getInitialProps(customContext)) as any | ||
|
|
||
| const apolloState = apolloClient.cache.extract() | ||
|
|
||
| return { | ||
| pageProps, | ||
| apolloState, | ||
| } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add error handling and improve getInitialProps implementation
The current implementation lacks error handling and doesn't account for components without getInitialProps methods.
SupportApplication.getInitialProps = async (appContext) => {
const { Component, ctx } = appContext
const apolloClient = initApollo({})
const customContext = {
...ctx,
apolloClient,
}
- const pageProps = (await Component.getInitialProps(customContext)) as any
+
+ let pageProps = {}
+ try {
+ if (Component.getInitialProps) {
+ pageProps = await Component.getInitialProps(customContext)
+ }
+ } catch (error) {
+ console.error('Error in getInitialProps:', error)
+ }
const apolloState = apolloClient.cache.extract()
return {
pageProps,
apolloState,
}
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| SupportApplication.getInitialProps = async (appContext) => { | |
| const { Component, ctx } = appContext | |
| const apolloClient = initApollo({}) | |
| const customContext = { | |
| ...ctx, | |
| apolloClient, | |
| } | |
| const pageProps = (await Component.getInitialProps(customContext)) as any | |
| const apolloState = apolloClient.cache.extract() | |
| return { | |
| pageProps, | |
| apolloState, | |
| } | |
| } | |
| SupportApplication.getInitialProps = async (appContext) => { | |
| const { Component, ctx } = appContext | |
| const apolloClient = initApollo({}) | |
| const customContext = { | |
| ...ctx, | |
| apolloClient, | |
| } | |
| let pageProps = {} | |
| try { | |
| if (Component.getInitialProps) { | |
| pageProps = await Component.getInitialProps(customContext) | |
| } | |
| } catch (error) { | |
| console.error('Error in getInitialProps:', error) | |
| } | |
| const apolloState = apolloClient.cache.extract() | |
| return { | |
| pageProps, | |
| apolloState, | |
| } | |
| } |
| import { setContext } from '@apollo/client/link/context' | ||
|
|
||
| const { publicRuntimeConfig, serverRuntimeConfig } = getConfig() | ||
| const isBrowser: boolean = process.browser |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Replace deprecated process.browser check
The process.browser check is deprecated in newer versions of Next.js.
-const isBrowser: boolean = process.browser
+const isBrowser: boolean = typeof window !== 'undefined'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const isBrowser: boolean = process.browser | |
| - const isBrowser: boolean = process.browser | |
| + const isBrowser: boolean = typeof window !== 'undefined' |
| export default function initApollo(initialState?: any) { | ||
| // Make sure to create a new client for every server-side request so that data | ||
| // isn't shared between connections (which would be bad) | ||
| if (!isBrowser) { | ||
| return create(initialState) | ||
| } | ||
|
|
||
| // Reuse client on the client-side | ||
| if (!apolloClient) { | ||
| apolloClient = create(initialState) | ||
| } | ||
|
|
||
| return apolloClient | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add proper TypeScript return type and parameter type
The initApollo function lacks proper TypeScript typing.
-export default function initApollo(initialState?: any) {
+export default function initApollo(initialState?: ApolloStateInterface): ApolloClient<any> {Committable suggestion skipped: line range outside the PR's diff.
| const authLink = setContext((_, { headers }) => { | ||
| const token = 'mock_token' | ||
| return { | ||
| headers: { | ||
| ...headers, | ||
| authorization: token ? `Bearer ${token}` : '', | ||
| }, | ||
| } | ||
| }) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve authentication token handling
The authentication token is currently hardcoded as 'mock_token'. This approach is not secure for production environments.
const authLink = setContext((_, { headers }) => {
- const token = 'mock_token'
+ // Get token from secure source (e.g., cookies, localStorage in browser)
+ const token = isBrowser
+ ? localStorage.getItem('auth_token') || 'mock_token'
+ : 'mock_token' // Use environment variable in production
return {
headers: {
...headers,
authorization: token ? `Bearer ${token}` : '',
},
}
})Committable suggestion skipped: line range outside the PR's diff.
| function create(initialState?: any) { | ||
| const { graphqlEndpoint: graphqlServerEndpoint } = serverRuntimeConfig | ||
| const { graphqlEndpoint: graphqlClientEndpoint } = publicRuntimeConfig | ||
| const graphqlEndpoint = graphqlServerEndpoint || graphqlClientEndpoint | ||
| const httpLink = new HttpLink({ | ||
| uri: graphqlEndpoint, | ||
| fetch, | ||
| }) | ||
|
|
||
| const retryLink = new RetryLink() | ||
|
|
||
| const errorLink = onError(({ graphQLErrors, networkError }) => { | ||
| if (graphQLErrors) | ||
| graphQLErrors.map(({ message, locations, path }) => | ||
| console.log( | ||
| `[GraphQL error]: Message: ${message}, Location: ${locations}, Path: ${path}`, | ||
| ), | ||
| ) | ||
|
|
||
| if (networkError) console.log(`[Network error]: ${networkError}`) | ||
| }) | ||
|
|
||
| const authLink = setContext((_, { headers }) => { | ||
| const token = 'mock_token' | ||
| return { | ||
| headers: { | ||
| ...headers, | ||
| authorization: token ? `Bearer ${token}` : '', | ||
| }, | ||
| } | ||
| }) | ||
|
|
||
| return new ApolloClient({ | ||
| link: ApolloLink.from([retryLink, errorLink, authLink, httpLink]), | ||
| connectToDevTools: isBrowser, | ||
| ssrMode: !isBrowser, // Disables forceFetch on the server (so queries are only run once) | ||
| cache: new InMemoryCache().restore(initialState || {}), | ||
| }) | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add proper TypeScript types and improve error handling
The code uses any type in multiple places and has limited error handling.
+interface ApolloStateInterface {
+ [key: string]: any;
+}
-function create(initialState?: any) {
+function create(initialState?: ApolloStateInterface) {
const { graphqlEndpoint: graphqlServerEndpoint } = serverRuntimeConfig
const { graphqlEndpoint: graphqlClientEndpoint } = publicRuntimeConfig
const graphqlEndpoint = graphqlServerEndpoint || graphqlClientEndpoint
const httpLink = new HttpLink({
uri: graphqlEndpoint,
fetch,
})
const retryLink = new RetryLink()
const errorLink = onError(({ graphQLErrors, networkError }) => {
if (graphQLErrors)
graphQLErrors.map(({ message, locations, path }) => {
console.log(
`[GraphQL error]: Message: ${message}, Location: ${locations}, Path: ${path}`,
)
+ // Consider reporting errors to an error tracking service
})
- if (networkError) console.log(`[Network error]: ${networkError}`)
+ if (networkError) {
+ console.log(`[Network error]: ${networkError}`)
+ // Implement recovery strategy or user notification
+ }
})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| function create(initialState?: any) { | |
| const { graphqlEndpoint: graphqlServerEndpoint } = serverRuntimeConfig | |
| const { graphqlEndpoint: graphqlClientEndpoint } = publicRuntimeConfig | |
| const graphqlEndpoint = graphqlServerEndpoint || graphqlClientEndpoint | |
| const httpLink = new HttpLink({ | |
| uri: graphqlEndpoint, | |
| fetch, | |
| }) | |
| const retryLink = new RetryLink() | |
| const errorLink = onError(({ graphQLErrors, networkError }) => { | |
| if (graphQLErrors) | |
| graphQLErrors.map(({ message, locations, path }) => | |
| console.log( | |
| `[GraphQL error]: Message: ${message}, Location: ${locations}, Path: ${path}`, | |
| ), | |
| ) | |
| if (networkError) console.log(`[Network error]: ${networkError}`) | |
| }) | |
| const authLink = setContext((_, { headers }) => { | |
| const token = 'mock_token' | |
| return { | |
| headers: { | |
| ...headers, | |
| authorization: token ? `Bearer ${token}` : '', | |
| }, | |
| } | |
| }) | |
| return new ApolloClient({ | |
| link: ApolloLink.from([retryLink, errorLink, authLink, httpLink]), | |
| connectToDevTools: isBrowser, | |
| ssrMode: !isBrowser, // Disables forceFetch on the server (so queries are only run once) | |
| cache: new InMemoryCache().restore(initialState || {}), | |
| }) | |
| } | |
| interface ApolloStateInterface { | |
| [key: string]: any; | |
| } | |
| function create(initialState?: ApolloStateInterface) { | |
| const { graphqlEndpoint: graphqlServerEndpoint } = serverRuntimeConfig | |
| const { graphqlEndpoint: graphqlClientEndpoint } = publicRuntimeConfig | |
| const graphqlEndpoint = graphqlServerEndpoint || graphqlClientEndpoint | |
| const httpLink = new HttpLink({ | |
| uri: graphqlEndpoint, | |
| fetch, | |
| }) | |
| const retryLink = new RetryLink() | |
| const errorLink = onError(({ graphQLErrors, networkError }) => { | |
| if (graphQLErrors) | |
| graphQLErrors.map(({ message, locations, path }) => { | |
| console.log( | |
| `[GraphQL error]: Message: ${message}, Location: ${locations}, Path: ${path}`, | |
| ) | |
| // Consider reporting errors to an error tracking service | |
| }) | |
| if (networkError) { | |
| console.log(`[Network error]: ${networkError}`) | |
| // Implement recovery strategy or user notification | |
| } | |
| }) | |
| const authLink = setContext((_, { headers }) => { | |
| const token = 'mock_token' | |
| return { | |
| headers: { | |
| ...headers, | |
| authorization: token ? `Bearer ${token}` : '', | |
| }, | |
| } | |
| }) | |
| return new ApolloClient({ | |
| link: ApolloLink.from([retryLink, errorLink, authLink, httpLink]), | |
| connectToDevTools: isBrowser, | |
| ssrMode: !isBrowser, // Disables forceFetch on the server (so queries are only run once) | |
| cache: new InMemoryCache().restore(initialState || {}), | |
| }) | |
| } |
|
|
||
| const Home = () => { | ||
| const { lang, formatDate, formatTime, formatMessage } = useLocale() | ||
| console.log('__intl formatMessage__', formatMessage) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove console.log statement
Debug logging statements should be removed in production code.
- console.log('__intl formatMessage__', formatMessage)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| console.log('__intl formatMessage__', formatMessage) |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
apps/hackathon-phi/README.md (4)
5-5: Fix grammar: "too tackle" → "to tackle"
The word “too” should be “to” in this context.- The idea of this app is too tackle the possible hackathon solution. + The idea of this app is to tackle a potential hackathon solution.🧰 Tools
🪛 LanguageTool
[uncategorized] ~5-~5: “too” (as well, very, ‘too much’) seems less likely than “to”.
Context: ... Phi ## About The idea of this app is too tackle the possible hackathon solution....(AI_HYDRA_LEO_CP_TOO_TO)
7-11: Capitalize "URLs" and update placeholders
Use the standard uppercase "URLs" and either replaceN/Awith actual environment links or temporarily remove the section until URLs are available.- ## Urls + ## URLs - Dev: N/A + Dev: <dev-url> - Staging: N/A - Production: N/A
13-17: Enhance "Getting started" instructions and verify the start command
- Add prerequisite steps (e.g.,
yarn install).- Confirm that
yarn start hackathon-phiis valid in your workspace; if not, use the proper Nx serve command (e.g.,yarn nx serve hackathon-phi).
21-22: Update the placeholder maintainer link
Replace the placeholder[Phi](link)with an actual link to the maintainer’s profile or repository, or reference the project’sCODEOWNERSfile if preferred.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/hackathon-phi/.babelrc(1 hunks)apps/hackathon-phi/README.md(1 hunks)apps/hackathon-phi/next-env.d.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/hackathon-phi/next-env.d.ts
🧰 Additional context used
📓 Path-based instructions (1)
`apps/**/*`: "Confirm that the code adheres to the following: - NextJS best practices, including file structure, API routes, and static generation methods. - Efficient state manage...
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/hackathon-phi/README.md
🪛 LanguageTool
apps/hackathon-phi/README.md
[uncategorized] ~5-~5: “too” (as well, very, ‘too much’) seems less likely than “to”.
Context: ... Phi ## About The idea of this app is too tackle the possible hackathon solution....
(AI_HYDRA_LEO_CP_TOO_TO)
🔇 Additional comments (1)
apps/hackathon-phi/.babelrc (1)
1-4: The Babel configuration looks appropriate for an Nx-managed Next.js application.The configuration correctly uses the
@nx/next/babelpreset which provides all the necessary Babel configurations for a Next.js application within an Nx workspace. The empty plugins array is a good starting point, allowing for additional plugins to be added as the application's needs evolve.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.devcontainer/Dockerfile (2)
3-3: Use consistent Dockerfile directive casingYou changed
as cargo-binstoAS cargo-bins. While Docker is case-insensitive for these keywords, it’s best practice to consistently uppercase all directives (FROM,AS,RUN, etc.) for readability across the repository.
12-13: Leverage BuildKit cache mounts forcargo installInvoking
cargo install starshipon every build can be slow. You can speed this up by caching the Cargo registry and Git index between builds:-RUN rustc --version && cargo --version && \ - cargo install starship --version 1.20.1 --verbose +RUN --mount=type=cache,target=/usr/local/cargo/registry \ + --mount=type=cache,target=/usr/local/cargo/git \ + rustc --version && cargo --version && \ + cargo install starship --version 1.20.1 --verboseThis will persist downloaded crates and Git checkouts to the build cache, reducing rebuild times.
.yarnrc.yml (1)
35-35: Add newline at end-of-file.Ensure the file ends with a newline character to satisfy YAML linters and POSIX file conventions.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 35-35: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (28)
.devcontainer/Dockerfile(2 hunks).yarnrc.yml(1 hunks)apps/hackathon-phi/server.ts(1 hunks)libs/api/domains/hackathon-phi/.eslintrc.json(1 hunks)libs/api/domains/hackathon-phi/README.md(1 hunks)libs/api/domains/hackathon-phi/jest.config.ts(1 hunks)libs/api/domains/hackathon-phi/project.json(1 hunks)libs/api/domains/hackathon-phi/src/index.ts(1 hunks)libs/api/domains/hackathon-phi/src/lib/api-domains-hackathon-phi.spec.ts(1 hunks)libs/api/domains/hackathon-phi/src/lib/api-domains-hackathon-phi.ts(1 hunks)libs/api/domains/hackathon-phi/src/lib/hackathon.module.ts(1 hunks)libs/api/domains/hackathon-phi/tsconfig.json(1 hunks)libs/api/domains/hackathon-phi/tsconfig.lib.json(1 hunks)libs/api/domains/hackathon-phi/tsconfig.spec.json(1 hunks)libs/api/hackathon-phi/.eslintrc.json(1 hunks)libs/api/hackathon-phi/README.md(1 hunks)libs/api/hackathon-phi/jest.config.ts(1 hunks)libs/api/hackathon-phi/project.json(1 hunks)libs/api/hackathon-phi/src/index.ts(1 hunks)libs/api/hackathon-phi/src/lib/api-hackathon-phi.spec.ts(1 hunks)libs/api/hackathon-phi/src/lib/api-hackathon-phi.ts(1 hunks)libs/api/hackathon-phi/tsconfig.json(1 hunks)libs/api/hackathon-phi/tsconfig.lib.json(1 hunks)libs/api/hackathon-phi/tsconfig.spec.json(1 hunks)libs/logging/src/lib/logging.ts(3 hunks)libs/nest/audit/src/lib/audit.service.ts(2 hunks)package.json(1 hunks)tsconfig.base.json(1 hunks)
✅ Files skipped from review due to trivial changes (24)
- libs/api/domains/hackathon-phi/README.md
- libs/api/domains/hackathon-phi/src/lib/hackathon.module.ts
- libs/api/hackathon-phi/README.md
- libs/api/domains/hackathon-phi/src/index.ts
- libs/api/hackathon-phi/src/lib/api-hackathon-phi.ts
- package.json
- libs/api/hackathon-phi/src/index.ts
- libs/api/domains/hackathon-phi/tsconfig.spec.json
- libs/api/hackathon-phi/src/lib/api-hackathon-phi.spec.ts
- libs/api/hackathon-phi/tsconfig.spec.json
- libs/api/hackathon-phi/tsconfig.json
- libs/api/domains/hackathon-phi/src/lib/api-domains-hackathon-phi.spec.ts
- libs/logging/src/lib/logging.ts
- libs/api/hackathon-phi/tsconfig.lib.json
- libs/api/domains/hackathon-phi/tsconfig.lib.json
- libs/api/domains/hackathon-phi/project.json
- libs/api/hackathon-phi/jest.config.ts
- tsconfig.base.json
- libs/api/domains/hackathon-phi/jest.config.ts
- libs/api/hackathon-phi/.eslintrc.json
- libs/api/domains/hackathon-phi/tsconfig.json
- libs/api/domains/hackathon-phi/src/lib/api-domains-hackathon-phi.ts
- libs/api/domains/hackathon-phi/.eslintrc.json
- libs/api/hackathon-phi/project.json
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/hackathon-phi/server.ts
🧰 Additional context used
📓 Path-based instructions (1)
`libs/**/*`: "Confirm that the code adheres to the following: - Reusability of components and hooks across different NextJS apps. - TypeScript usage for defining props and exportin...
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/nest/audit/src/lib/audit.service.ts
🪛 YAMLlint (1.35.1)
.yarnrc.yml
[error] 35-35: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.devcontainer/Dockerfile (1)
1-1: Confirm Rust version bump compatibilityThe
RUST_VERSIONARG has been updated from 1.78 to 1.81. Before merging, ensure that any Rust code, tooling, or CI jobs relying on the previous Rust version are compatible with 1.81. Update any.rust-toolchainfiles or GitHub Actions workflows accordingly to prevent mismatches.Also applies to: 3-3
libs/nest/audit/src/lib/audit.service.ts (1)
2-2: Improved type safety for Winston CloudWatch integration.This change properly imports and utilizes the
LogObjecttype from winston-cloudwatch, improving the type safety of themessageFormatterfunction. By explicitly typing the function as(logObject: LogObject) => string, you ensure better compatibility with theWinstonCloudWatchtransport while maintaining the same functional behavior.This is consistent with the library coding guidelines as it:
- Enhances reusability by making the type contract more explicit
- Properly leverages TypeScript for type definitions
- Maintains good bundling practices by importing only what's needed
Also applies to: 58-60
.yarnrc.yml (1)
28-35: Approve: Enforce consistent ioredis version via packageExtensions.The
packageExtensionsentries for[email protected]and[email protected]correctly pin both to[email protected], matching the rootpackage.jsonresolution. This prevents dependency mismatches and duplicate installations across the workspace.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 35-35: no new line character at the end of file
(new-line-at-end-of-file)
No description provided.