Skip to content

ci: Generate values.yaml files for feature-deployment more cleanly #18852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pro-ingvar
Copy link
Member

@pro-ingvar pro-ingvar commented Apr 23, 2025

Summary by CodeRabbit

  • Chores
    • Updated workflow to streamline script execution and remove unnecessary git operations.
    • Modified directory structure for generated feature files to simplify output locations.
    • Updated .gitignore to exclude the charts/features directory from version control.

@pro-ingvar pro-ingvar added the deploy-feature Deploys features to dev label Apr 23, 2025
Copy link
Contributor

coderabbitai bot commented Apr 23, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update a GitHub Actions workflow, a shell script, and the .gitignore file. The workflow now calls the generate-feature-values.sh script once with all images as an argument, removing the previous per-image loop and all git-related commands. The shell script is modified to create a simpler directory structure by eliminating per-image subdirectories. The .gitignore is updated to exclude the charts/features directory from version control.

Changes

File(s) Change Summary
.github/workflows/push.yml Refactored to remove per-image loop and git commands; now calls generate-feature-values.sh once for all images.
infra/scripts/generate-feature-values.sh Simplified directory creation; removed per-image subdirectory, outputs now go to a shared feature directory.
.gitignore Added charts/features to ignore list to prevent tracking of this directory.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant generate-feature-values.sh
    participant File System

    GitHub Actions->>generate-feature-values.sh: Run with all images as argument
    generate-feature-values.sh->>File System: Create $FEATURE_DIR/$FEATURE_NAME
    generate-feature-values.sh->>File System: Write outputs to $FEATURE_DIR/$FEATURE_NAME
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pro-ingvar pro-ingvar force-pushed the fd-update-value-file-creation branch from f89689d to 0fe2da0 Compare April 23, 2025 13:25
Copy link

nx-cloud bot commented Apr 23, 2025

View your CI Pipeline Execution ↗ for commit 58d3a4f.

Command Status Duration Result
nx run-many --target=codegen/frontend-client --... ✅ Succeeded 13s View ↗
nx run-many --target=codegen/backend-schema --a... ✅ Succeeded 5s View ↗
nx run-many --target=codegen/backend-client --a... ✅ Succeeded 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 14:03:48 UTC

@pro-ingvar pro-ingvar force-pushed the fd-update-value-file-creation branch from ab9192a to 9093fcb Compare April 23, 2025 13:42
Copy link
Contributor

github-actions bot commented Apr 23, 2025

Affected services are: 'web'
Feature deployment of your services will begin shortly. Your feature will be accessible here:
https://fd-update-value-file-creation-beta.dev01.devland.is/

Deployed services: web.
Excluded services: ``

@pro-ingvar pro-ingvar added deploy-feature Deploys features to dev and removed deploy-feature Deploys features to dev labels Apr 23, 2025
@pro-ingvar pro-ingvar force-pushed the fd-update-value-file-creation branch from 9093fcb to 3af3ca2 Compare April 25, 2025 09:40
@pro-ingvar pro-ingvar added the deploy-feature Deploys features to dev label Apr 25, 2025
@pro-ingvar pro-ingvar force-pushed the fd-update-value-file-creation branch from 3af3ca2 to 4bb8b1f Compare April 25, 2025 10:33
@pro-ingvar pro-ingvar added test everything 💀 test & build everything 💀 and removed test everything 💀 test & build everything 💀 labels Apr 25, 2025
@pro-ingvar pro-ingvar force-pushed the fd-update-value-file-creation branch from bf5769b to 4bb8b1f Compare April 25, 2025 12:10
@pro-ingvar
Copy link
Member Author

@CodeRabbit summary

Copy link
Contributor

coderabbitai bot commented Apr 25, 2025

✅ Actions performed

Summary regeneration triggered.

@pro-ingvar
Copy link
Member Author

@coderabbitai summary

Copy link
Contributor

coderabbitai bot commented Apr 25, 2025

✅ Actions performed

Summary regeneration triggered.

@pro-ingvar pro-ingvar force-pushed the fd-update-value-file-creation branch 2 times, most recently from af68f3f to dd5dc98 Compare April 25, 2025 12:58
@pro-ingvar pro-ingvar force-pushed the fd-update-value-file-creation branch from dd5dc98 to 58d3a4f Compare April 25, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-feature Deploys features to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant