fix(secondary school): Add check for applicationDataHasBeenPruned #18968
+53
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new utility function, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant OverviewComponent
participant HelperFunctions
participant Messages
User->>OverviewComponent: Render Overview
OverviewComponent->>HelperFunctions: applicationDataHasBeenPruned(answers)
HelperFunctions-->>OverviewComponent: true/false
alt Data has been pruned
OverviewComponent->>Messages: Get pruned state message (by application state)
Messages-->>OverviewComponent: Localized message
OverviewComponent-->>User: Show pruned message
else Data not pruned
OverviewComponent-->>User: Show detailed overview components
end
sequenceDiagram
participant User
participant SubmittedForm
participant HelperFunctions
User->>SubmittedForm: Interact with form
SubmittedForm->>HelperFunctions: applicationDataHasBeenPruned(answers)
HelperFunctions-->>SubmittedForm: true/false
alt Data has been pruned
SubmittedForm-->>User: Hide alerts, disable submit
else Data not pruned
SubmittedForm-->>User: Show alerts (if applicable), enable submit
end
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
6 tasks
jonarnarbriem
approved these changes
May 9, 2025
libs/application/templates/secondary-school/src/utils/helperFunctions/index.ts
Show resolved
Hide resolved
|
View your CI Pipeline Execution ↗ for commit a4fdd0f.
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
libs/application/templates/secondary-school/src/utils/helperFunctions/index.ts (1)
13-15: Add JSDoc comments to explain this new utility function.This function seems to be checking whether an application's data has been pruned by checking if
approveExternalDatais falsy. Adding a JSDoc comment would help other developers understand the reasoning behind this implementation.+/** + * Checks if the application data has been pruned. + * @param answers The application form values + * @returns True if the application data has been pruned (when approveExternalData is false/undefined) + */ export const applicationDataHasBeenPruned = (answers: FormValue) => { return !getValueViaPath<boolean>(answers, 'approveExternalData') }libs/application/templates/secondary-school/src/fields/overview/index.tsx (1)
15-24: Consider extracting the message rendering logic into a helper component.The conditional rendering block could be extracted into a separate component for better readability and maintainability, especially if this pattern might be reused elsewhere.
+const PrunedDataMessage = ({ state }: { state: string }) => { + const { formatMessage } = useLocale() + + if (state === States.SUBMITTED) { + return <>{formatMessage(overview.applicationDataHasBeenPruned.submitted)}</> + } + + if (state === States.IN_REVIEW) { + return <>{formatMessage(overview.applicationDataHasBeenPruned.inReview)}</> + } + + if (state === States.COMPLETED) { + return <>{formatMessage(overview.applicationDataHasBeenPruned.completed)}</> + } + + return null +} export const Overview: FC<FieldBaseProps> = (props) => { const { formatMessage } = useLocale() return applicationDataHasBeenPruned(props.application.answers) ? ( <Box> - {props.application.state === States.SUBMITTED && - formatMessage(overview.applicationDataHasBeenPruned.submitted)} - {props.application.state === States.IN_REVIEW && - formatMessage(overview.applicationDataHasBeenPruned.inReview)} - {props.application.state === States.COMPLETED && - formatMessage(overview.applicationDataHasBeenPruned.completed)} + <PrunedDataMessage state={props.application.state} /> </Box> ) : (libs/application/templates/secondary-school/src/forms/submittedForm.ts (3)
37-41: Improve readability with a descriptive variable name.The condition logic is duplicated in multiple places. Consider creating a descriptive helper function or variable to make the intent more clear.
condition: (answers) => { + const isDataAvailableForDisplay = !applicationDataHasBeenPruned(answers); return ( - !applicationDataHasBeenPruned(answers) && + isDataAvailableForDisplay && checkIsFreshman(answers) ) },
49-53: Improve readability with a descriptive variable name.Similar to the previous comment, use a descriptive variable to improve readability.
condition: (answers) => { + const isDataAvailableForDisplay = !applicationDataHasBeenPruned(answers); return ( - !applicationDataHasBeenPruned(answers) && + isDataAvailableForDisplay && !checkIsFreshman(answers) ) },
70-70: Consistency with other conditions.For consistency with other conditions in this file, consider using the same descriptive variable approach here as well.
-condition: (answers) => !applicationDataHasBeenPruned(answers), +condition: (answers) => { + const isDataAvailableForDisplay = !applicationDataHasBeenPruned(answers); + return isDataAvailableForDisplay; +},
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
libs/application/templates/secondary-school/src/fields/overview/index.tsx(1 hunks)libs/application/templates/secondary-school/src/forms/submittedForm.ts(4 hunks)libs/application/templates/secondary-school/src/lib/messages/overview.ts(1 hunks)libs/application/templates/secondary-school/src/utils/helperFunctions/index.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`libs/**/*`: "Confirm that the code adheres to the following: - Reusability of components and hooks across different NextJS apps. - TypeScript usage for defining props and exportin...
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/secondary-school/src/utils/helperFunctions/index.tslibs/application/templates/secondary-school/src/forms/submittedForm.tslibs/application/templates/secondary-school/src/fields/overview/index.tsxlibs/application/templates/secondary-school/src/lib/messages/overview.ts
🧬 Code Graph Analysis (1)
libs/application/templates/secondary-school/src/forms/submittedForm.ts (1)
libs/application/templates/secondary-school/src/utils/helperFunctions/index.ts (1)
applicationDataHasBeenPruned(13-15)
libs/application/templates/secondary-school/src/lib/messages/overview.ts
Outdated
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
|
johannaagma
deleted the
fix/secondary-shcool-handle-if-submitted-application-was-pruned-once
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
Note: We can revert all this stuff when the applications for this term can actually be pruned
What
Display some information if application that has been submitted, but all the data has been accidentally pruned
Why
12 applications were accidentally pruned in end of april 2025
Screenshots / Gifs
If state = submitted :
If state = inReview:
If state = completed:
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes