Expose concurrency flag of envoy

[mcieplak]

This is to address the following github issue: #3031

[istio-testing]

Hi @mcieplak. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[andraxylia]

/lgtm

[andraxylia]

@mcieplak Thanks for your PR! Can you please sign the CLA?

[mcieplak]

@andraxylia No problem! I just signed the CLA now. This PR is also dependent on istio/api#341 being merged. I will send another PR to handle the kube-inject side as well.

[googlebot]

CLAs look good, thanks!

[istio-merge-robot]

/lgtm cancel //PR changed after LGTM, removing LGTM. @andraxylia @mcieplak

[andraxylia]

Test fail because the corresponding istio/api change has not been merged yet.

[andraxylia]

Please update the istio/api sha to 8d86ca7 in the dependency file here and then to /restest

https://github.com/istio/istio/blob/master/Gopkg.lock#L1058

[andraxylia]

/ok-to-test

[mcieplak]

@andraxylia Thank you for the updates!

@costinm I have updated the PR to only add the concurrency flag if it's specified. Please review.

[mcieplak]

@andraxylia The build is now passing. Can you please review?

[andraxylia]

e2e-smoke and istio-pilot-e2e failure caused by #3139

[andraxylia]

@costinm tests are passing, please check the code changes, remove the hold label and merge if everything is fine.

[mcieplak]

@andraxylia I believe the e2e-pilot ci/circleci test is also failing because of #3139.

[costinm]

/lgtm

[istio-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, costinm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pilot/OWNERS [andraxylia,costinm]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[mcieplak]

@andraxylia @costinm Thank you for the reviews! Can we please merge?

[istio-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[rkpagadala]

/test istio-unit-tests

[istio-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[istio-merge-robot]

Automatic merge from submit-queue.