Enable Overriding of Hashables with allow_override=True #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code modification enables hashables to be overwritten when the allow_override parameter is set to True. Previously, the library would crash if a hashable was overwritten. This change allows overrides, preventing the library from crashing in such scenarios. Thanks to @jjlangen for contributing to this change.
|
@ivankorobkov any chance of getting this merged? |
|
Hi, Well, the library was designed specifically to prevent duplicates and overrides. Overriding quite quickly can lead to complex, even messy, hard-to-maintain code. Do you really need this? If you do, I will merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code modification enables hashables to be overwritten when the allow_override parameter is set to True. Previously, the library would crash if a hashable was overwritten. This change allows overrides, preventing the library from crashing in such scenarios.
Thanks to @jjlangen for contributing to this change.