NeuralNet interface #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denravonska
force-pushed
the
nn-interface
branch
from
064c5a7 to
67f651a
Compare
Needs to be test built for Windows.
denravonska
force-pushed
the
nn-interface
branch
from
67f651a to
2b2e124
Compare
denravonska
commented
Dec 22, 2018
| } | ||
|
|
||
| INeuralNetPtr NN::CreateNeuralNet() | ||
| { |
There was a problem hiding this comment.
With the new scraper NN the body will look something like this:
if(new scraper enabled)
return NewScraperNN
// Fallback to default implementations
#ifdef WIN32
return Win32NN
#else
return StubNN
#endif
The ifdef is still needed since the Win32 NN calls Qt. We can get around this by injecting a DotNetExecutor or Bridge object which does the actual call. If you instantiate from Qt it will inject a QAxObject capable executor, otherwise it injects a dummy executor. That will also allow us to stop making NN implementation selections at compile time.
|
I am going ahead and merging this. |
jamescowens
pushed a commit
that referenced
this pull request
Jan 6, 2019
Populate testnet bad claim block list and wire in
jamescowens
referenced
this pull request
Jan 8, 2019
jamescowens
pushed a commit
that referenced
this pull request
Nov 21, 2019
Close LevelDB before installing a snapshot
jamescowens
added a commit
that referenced
this pull request
Jun 24, 2022
This replaces the temporary MRC request contract icon with the winner of the icon poll on mainnet. See https://www.reddit.com/r/gridcoin/comments/v3suih/mrc_icon_poll/ The poll id is 4e3e06e88c5315eff95365a40d3a12d7dbd14205dc775c645c9f8b9dd2e99dc9 The winning icon is #7. Many thanks to m3prx for contributing the winning icon! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft for using interfaces and a factory for the NeuralNet. This should allow us to easily write a third implementation which uses the new scraper code, and conditionally instantiate it in
NN::CreateNeuralNet()based on the user's configuration flags.I have not tested this in Windows yet.