Skip to content

Support custom tarball name #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

kerner1000
Copy link
Contributor

No description provided.

@fvarrui
Copy link
Collaborator

fvarrui commented Jan 8, 2023

Why don't you use a plugin like copy-rename-maven-plugin after packaging for this?

Anyway, if we finally include this new feature, it has to be extended for Gradle and offer the same for zipballs, giving coherence to the plugin. What do you think? Would you like to implement it? 😅

@kerner1000
Copy link
Contributor Author

Oh, I did not know about copy-rename-maven-plugin :)

I will update the PR to include according changes for the grade packager and the zipball.

@kerner1000 kerner1000 force-pushed the feature/custom-tarball-name branch from ff21020 to a7d8a19 Compare January 9, 2023 11:55
@kerner1000
Copy link
Contributor Author

Updated.

@fvarrui fvarrui merged commit 23e1142 into javapackager:devel Jan 12, 2023
@fvarrui
Copy link
Collaborator

fvarrui commented Jan 12, 2023

Thanks so much!

@fvarrui
Copy link
Collaborator

fvarrui commented Jan 12, 2023

Ohh ... docs should also be updated with the new plugin properties 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants