Skip to content

Dropped support for Python 2.7 and 3.5 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Conversation

smithdc1
Copy link
Contributor

@smithdc1 smithdc1 commented Dec 7, 2020

  • Removed Python2 from test matrix

  • Removed six dependency

  • Removed Python2 code

- Removed Python2 from test matrix

- Removed six dependency

- Removed Python2 code
@smithdc1 smithdc1 requested a review from hramezani December 7, 2020 20:26
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #105 (6711115) into master (a1f8b81) will decrease coverage by 3.04%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   81.87%   78.83%   -3.05%     
==========================================
  Files           7        7              
  Lines         149      137      -12     
  Branches       19       14       -5     
==========================================
- Hits          122      108      -14     
- Misses         20       21       +1     
- Partials        7        8       +1     
Impacted Files Coverage Δ
src/robots/models.py 81.25% <50.00%> (-2.97%) ⬇️
src/robots/views.py 72.05% <66.66%> (-2.95%) ⬇️
src/robots/admin.py 100.00% <100.00%> (ø)
src/robots/forms.py 72.72% <100.00%> (-5.85%) ⬇️
src/robots/settings.py 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f8b81...6711115. Read the comment docs.

@smithdc1
Copy link
Contributor Author

smithdc1 commented Dec 7, 2020

Thank you @hramezani for the review. 🦸

@smithdc1 smithdc1 merged commit 4e07737 into jazzband:master Dec 7, 2020
@smithdc1 smithdc1 deleted the python2 branch December 7, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants