Disable incremental regen when Archives enabled for 3.0 compatibility #48
Conversation
Signed-off-by: Alfred Xing <[email protected]>
|
Oops. Applying @pathawks' commit from his PR. |
| @@ -13,7 +13,7 @@ Gem::Specification.new do |s| | |||
| s.licenses = ["MIT"] | |||
| s.files = ["lib/jekyll-archives.rb", "lib/jekyll-archives/archive.rb"] | |||
|
|
|||
| s.add_dependency "jekyll", '>= 2.4' | |||
| s.add_dependency "jekyll", '~> 3.0.0.pre.beta8' | |||
There was a problem hiding this comment.
this version of jekyll-archives won't be compatible with jekyll 2. is that intended?
There was a problem hiding this comment.
If this won't be compatible, will Ruby/Bundler be smart about it and install an older version of the gem if the user is using Jekyll 2?
Otherwise I can wrap the addition of the hook with a conditional to still make it compatible...
There was a problem hiding this comment.
Yeah, would you wrap all 3.0-specific pieces?
|
no incremental regen makes me sad. 😭 😉 |
|
Cool! ⛄ |
alfredxing
force-pushed
the
3.0-compatibility
branch
from
bbf11b3 to
de58dec
Compare
|
OK, all tests passed this time, with Jekyll 2 compatibility kept. |
|
Thanks, Alfred!!!!!! |
|
Perhaps a note re: incremental regen being disabled should be added to the Readme? |
|
Great idea! |
|
Cool. I’ll write some words when I get a chance. |
|
👍 |
Incremental regen messes up the content of generated archives (they show raw content instead of generated content), so we need to disable it if
jekyll-archivesis included as a gem.Should fix the failing test(s) from #47.
For jekyll/jekyll#3945
@parkr @pathawks