Update Jekyll-Archives on RubyGems.org to support Jekyll 3 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Right now I am using jekyll-archives sourced from the GitHub master branch, which I think is working. This feels like a hack until the gem dependency is updated. |
|
Thanks! Though I don't think that the Travis build version is the issue that is causing this, I think it's just because I haven't released the latest version yet (which I will do now!) I'll merge in this PR though, since everything here is helpful! |
alfredxing
added a commit
that referenced
this pull request
Oct 27, 2015
|
@alfredxing Thanks. |
|
No problem! I just realized that #51 is still outstanding, so I'll be waiting for that before I release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alfredxing
@parkr
I'm using Bundler in order to manage gem dependencies for Jekyll. In order to upgrade to Jekyll 3, I was running the command
bundle update. Unfortunately Bundle wasn't upgrading to v3.0.0 and was still using Jekyll 2. After investigation i found out only removing "jekyll-archives" from the Gemfile will solve the problem.Reason:
The Gem page on RubyGems.org is using v2.0.0 with the fixed dependency
jekyll ~> 2.4. See attached screenshot.On the master branch (aka HEAD) the dependency issue is already fixed.
So let's increase the version of Jekyll-Archives, so that the changes for Jekyll 3 will be available on RubyGems.org.
ToDo after merge: