Render layouts with full site.archives
#59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix jekyll#37 actually. Using `site.archives` on anywhere except the layout of jekyll-archives works, but when we render the layout of archives `site.archives` is empty. So we need to collect all archives first, and then set `site.archives` to allow accessing from the layout of jekyll-archives.
|
Too bad this wasn't merged yet, what's holding this back? |
|
Sorry for the delay! I was away from the project for quite a while (school & summer internship) 😞 This should be fixed with #67, though! Feel free to confirm on your side and let me know if it works! |
|
It works on master, so closing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #37 actually. Using
site.archiveson anywhere except the layout of jekyll-archives works, but when we render the layout of archivessite.archivesis empty. So we need to collect all archives first, and then setsite.archivesto allow accessing from the layout of jekyll-archives.