Skip to content

Update develocity-injection init script to v1.2 #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

bot-githubaction
Copy link
Collaborator

Updates the develocity-injection init script to the latest reference script content
from https://github.com/gradle/develocity-ci-injection.

Updates the develocity-injection init script to the latest reference script content
from https://github.com/gradle/develocity-ci-injection.
@alextu
Copy link
Contributor

alextu commented Feb 6, 2025

@bigdaz the Gradle plugin version is configurable by the user, which means it can be set to an older version compatible with Gradle < 5. If we formally constrain the versions in the init script, then we need to accommodate the CI integrations to validate the DV Gradle plugin version configured by users.

@bigdaz
Copy link
Collaborator

bigdaz commented Feb 6, 2025

The init-script will automatically apply com.gradle.build-scan:1.16 for any Gradle version older than 5.0. So there's never a reason to configure this version for injection.

The reason for the new check DV-plugin version check is that we don't test the init-script for a wider range of configured DV plugin versions, and that older versions are largely broken with the CCUD Gradle plugin.

But I see your point about validating the input in the UI. We already had a check in the init-script that CCUD Gradle plugin version is > 1.7. Do we validate that in the UI now?

The init script takes care of adapting the plugin version to old Gradle version.
@alextu alextu merged commit a5fa430 into master Feb 10, 2025
15 of 23 checks passed
@alextu alextu deleted the bot/develocity-injection-init-script-update branch February 10, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants