Add custom dispatcher to builtin_string #4661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
requested changes
Apr 23, 2021
| } | ||
| case ECMA_BUILTIN_STRING_OBJECT_RAW: | ||
| { | ||
| return ecma_builtin_string_object_raw (this_arg, arguments_list_p, arguments_number); |
There was a problem hiding this comment.
argument this is all unused in all these three functions, and the behavior is same when no arguments is passed. This common part should be the part of the dispatcher
zherczeg
requested changes
May 26, 2021
JerryScript-DCO-1.0-Signed-off-by: Orkenyi Virag [email protected]
rerobika
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Virag Orkenyi [email protected]