fix: implement just-in-time test file list updates #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change optimizes file system event handling by implementing a just-in-time approach to updating test file lists. Rather than immediately refreshing the test file list on every file system event, we now mark it as dirty and only update it when necessary (before running tests). - Add testFileListDirty flag to track when updates are needed - Only update test file list when running or debugging tests - Force update on initial startup for completeness - Significantly improves performance when renaming files in large repositories fixes jest-community#1196
connectdotz
reviewed
Apr 14, 2025
There was a problem hiding this comment.
@christianvuerings, Thanks for the PR! A few questions before we dive into the code:
- Does
updateTestFileList()not cause issues in your setup? We've heard from some users that it introduces noticeable delays at startup, which is why we added the "defer" runMode. I'm wondering if it might make sense to integrate this behavior into the defer mode instead? 🤔 - I see you've added dirty state checks for
debugandrunAllTests, good, but I didn't see a similar check for individual test item runs (intest-provider/test-item-data.ts). Also, having to add this check in multiple places feels a bit... less than ideal. 🤔 - Also, should we consider letting users know when
updateTestFileList()is running—so they understand why running a seemingly small test could have noticeable delay due to this deferred action? That said, the notice has to be non-intrusive… - I am also wondering how to we let user know the test file related stats (UI) are "dirty"? For example, in
TestResultProvider.getTestSuiteStats(), and possibly other test-file-dependent info that we may need to test/review carefully for the impact of this new "dirty" state.
Pull Request Test Coverage Report for Build 14434728301Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change optimizes file system event handling by implementing a just-in-time approach to updating test file lists. Rather than immediately refreshing the test file list on every file system event, we now mark it as dirty and only update it when necessary (before running tests).
fixes #1196