Skip to content

refactor(jest-cli): reduce nesting in the package #13395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2022
Merged

refactor(jest-cli): reduce nesting in the package #13395

merged 4 commits into from
Oct 6, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

The cli/ directory looks redundant. I think file from that directory could simply live in src/ and their tests in src/__tests__/ instead of src/__tests__/cli/.

I also renamed fixtures/ to __fixtures__/ to simplify the testPathIgnorePatterns in Jest config.

Test plan

This is PR is just about renaming. Tests should pass.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit 2ecf723 into jestjs:main Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
@mrazauskas mrazauskas deleted the refactorjest-cli-reduce-nesting branch November 8, 2022 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants