Skip to content

chore: prefer .includes over indexOf #14524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 14, 2023

Summary

Performance is essentially the same, but it's way more readable

image

Test plan

Green CI

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e5c69b5
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6502e824c53d80000874dbf9
😎 Deploy Preview https://deploy-preview-14524--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB SimenB merged commit 8cc8dae into jestjs:main Sep 14, 2023
@SimenB SimenB deleted the eslint-prefer-includes branch September 14, 2023 13:13
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant